Skip to content

Commit 2b0da61

Browse files
committed
clarify comment
1 parent df513da commit 2b0da61

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

SCCACHE.md

+3
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@ and set `MOUNT_ROOT` to `/tmp/muslrust` in CI. (`$HOME` may or may not work corr
110110

111111
The only reason to get fancier with the gha cache keys here is if you have lots of jobs using this and for some reason you don't expect them to be able to share artifacts.
112112
For example, if you are using `muslrust:stable` and `muslrust:nightly`, probably nothing at all can be shared between these builds so you might as well use separate github cache keys for those.
113+
That's an efficiency consideration -- there's no point to have the `muslrust:nightly` job download a bunch of cached artifacts from the `muslrust:stable` job that there's no way it can get hits on,
114+
it will just slow down your CI a bit because it downloads stuff it doesn't need. But it's not a correctness consideration. Even if the `muslrust:nightly` stuff got into your `SCCACHE_DIR` on a job
115+
using `muslrust:stable`, it shouldn't cause a bad build, because `sccache` caching is sound.
113116

114117
Note that per docu, github has a repository limit of 10G in total for all caches created this way. I suggest using 5G as the `SCCACHE_CACHE_SIZE` and leaving some G's for the `.cargo/registry`, but ymmv.
115118

0 commit comments

Comments
 (0)