From cf7938834e946c121161cd3301300415f3a13bca Mon Sep 17 00:00:00 2001 From: beyondszine Date: Wed, 30 Jan 2019 17:30:18 +0530 Subject: [PATCH 1/2] made port a variable in docker file & added tini for initial signal handling --- Dockerfile | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index ef51fe2..f14efe3 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,8 +5,16 @@ RUN npm install -g json-server WORKDIR /data VOLUME /data +ENV PORT 8000 -EXPOSE 80 +# Expose ports +EXPOSE ${PORT} ADD run.sh /run.sh -ENTRYPOINT ["bash", "/run.sh"] -CMD [] + +# adding tini bcz json server doesn't do error handling. +ENV TINI_VERSION v0.18.0 +ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini +RUN chmod +x /tini + +ENTRYPOINT ["/tini", "-g", "--", "bash", "/run.sh"] +CMD [] \ No newline at end of file From 56dd958e61c4208ce12aa191eb57b0c4d1336699 Mon Sep 17 00:00:00 2001 From: beyondszine Date: Wed, 30 Jan 2019 17:32:30 +0530 Subject: [PATCH 2/2] 1. port as variable in args using from dockerfile. 2. listening on all interfaces to be accessible from host system too. --- run.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/run.sh b/run.sh index 6af0f54..882e321 100755 --- a/run.sh +++ b/run.sh @@ -2,12 +2,12 @@ args="$@" -args="$@ -p 80" +args="$@ -p $PORT --host 0.0.0.0" file=/data/db.json if [ -f $file ]; then echo "Found db.json, trying to open" - args="$args db.json" + args="$args $file" fi file=/data/file.js