Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check data availability for Visualization widgets #865

Open
longshuicy opened this issue Jan 9, 2024 · 2 comments · May be fixed by #902
Open

Check data availability for Visualization widgets #865

longshuicy opened this issue Jan 9, 2024 · 2 comments · May be fixed by #902
Assignees
@ddey2
Labels
bug Something isn't working enhancement New feature or request
Milestone
v2.0-beta-4

Comments

@longshuicy
Copy link
Member

longshuicy commented Jan 9, 2024 •
edited by lmarini
Loading

Bug: Empty visualizations show up. For example with the Vega visualization (given a config, show visualization) matches json, but if the config is not set it can't render. It will render the white tile with no content any time there is a JSON file.

We could have a method that the visualization widget/ or developer manually implements to check if all the input data is available and whether the vis widget should be shown or not.
@longshuicy longshuicy moved this to Todo in Clowder v2 Sprints Jan 9, 2024
@lmarini lmarini added the enhancement New feature or request label Jan 9, 2024
@lmarini lmarini added this to the v2.0-beta-2 milestone Jan 9, 2024
@lmarini lmarini modified the milestones: v2.0-beta-2, v2.0-beta-3 Jan 18, 2024
@lmarini lmarini added the bug Something isn't working label Jan 18, 2024
@lmarini lmarini moved this to Todo in Clowder v2 Roadmap Jan 18, 2024
@tcnichol tcnichol assigned tcnichol and unassigned tcnichol Jan 25, 2024
@ddey2 ddey2 moved this from Todo to In Progress in Clowder v2 Sprints Jan 26, 2024
@ddey2 ddey2 moved this from Todo to In Progress in Clowder v2 Roadmap Jan 26, 2024
@ddey2 ddey2 linked a pull request Jan 29, 2024 that will close this issue
add check if no config present and main type is application #902
Draft
@ddey2
Copy link
Member

ddey2 commented Jan 29, 2024

I was wondering if we can add a check on the frontend. We check for configs on the frontend already, was thinking if a backend call is really necessary. I added a draft pR to show what I try to mean.

@ddey2
Copy link
Member

ddey2 commented Feb 9, 2024

Thought - We want to add an interface which has some function like isVisDataRequirementsMet() and we want to make it mandatory to implement this function in all the vis components like Audio.tsx, VegaSpec.tsx

The way we might want to achieve the above in typescript and React is yet to be explored. Some links alreday explore:
https://www.typescriptlang.org/docs/handbook/interfaces.html

@lmarini lmarini modified the milestones: v2.0-beta-3, v2.0-beta-4 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddey2 ddey2

Labels
bug Something isn't working enhancement New feature or request
Projects
Clowder v2 Roadmap
Status: In Progress
Clowder v2 Sprints
Status: In Progress
Milestone
v2.0-beta-4
Development

Successfully merging a pull request may close this issue.

add check if no config present and main type is application clowder-framework/clowder2
4 participants
@lmarini @longshuicy @ddey2 @tcnichol