fix: add a newline to the password decrypt command #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of the command `echo "${encrypted_password}" | base64 --decode | keybase pgp decrypt` does not have a newline character at the end of the line, so the decrypted password is either mixed with prompt (bash) or has a trailing character ('%' or '#' in zsh).
hans-d
added
wip
|
/terratest |
|
@b1n9s can you update the readme as per the failing readme check ? |
|
Thanks @b1n9s for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
|
/terratest |
|
@b1n9s should not the command be |
|
@goruha, sorry I lost track of this PR, the purpose of this PR is to add a new line to the output, so the trailing '%' won't be shown in the output in zsh. change to |
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the command
echo "${encrypted_password}" | base64 --decode | keybase pgp decryptdoes not have a newline character at the end of the line, so the decrypted password is either mixed with the prompt (bash) or has a trailing character ('%' or '#' in zsh).what
why
The output of the command
echo "${encrypted_password}" | base64 --decode | keybase pgp decryptdoes not have a newline character at the end of the line, so the decrypted password is either mixed with prompt (bash) or has a trailing character ('%' or '#' in zsh).This commit pipes the decrypted password to echo to force a newline.
references
https://zsh.sourceforge.io/Doc/Release/Options.html#Prompting