feat: update module to use new ALB ingress module #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhosteny
commented
Feb 25, 2021
jhosteny
commented
Feb 25, 2021
jamengual
reviewed
Feb 25, 2021
This change updates the ALB ingress module so that we can pass the OIDC scope setting through unaltered. Fixes cloudposse#90.
jhosteny
force-pushed
the
feat/update-alb-ingress
branch
from
3edfc2c to
1b78fc3
Compare
|
/test all |
|
/test all |
jamengual
previously approved these changes
Feb 25, 2021
nitrocode
previously approved these changes
Feb 25, 2021
|
Might as well upgrade the source to the latest version of the alb ingress module |
|
/test all |
|
Also remove this from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.
Fixes #90.
what
why
references