Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module according to new ALB ingress scope semantics #90

Open
jhosteny opened this issue Jan 27, 2021 · 0 comments
Open

Update module according to new ALB ingress scope semantics #90

jhosteny opened this issue Jan 27, 2021 · 0 comments
Assignees
@jhosteny

Comments

@jhosteny
Copy link
Contributor

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

Pass through Cognito / OIDC scopes unaltered, after cloudposse/terraform-aws-alb-ingress#45 is merged.

Expected Behavior

Update the module to use the latest changes from the ALB ingress module.

Use Case

The intent of the change is to move the logic on scope formation to the user of the module, since it may vary across IdP.

Describe Ideal Solution

N/A

Alternatives Considered

N/A

Additional Context

N/A
@jhosteny jhosteny self-assigned this Jan 27, 2021
jhosteny added a commit to thoroai/terraform-aws-ecs-web-app that referenced this issue Jan 27, 2021
@jhosteny
feat: update module to use new ALB ingress module
c316e5b 
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes cloudposse#90.
jhosteny added a commit to thoroai/terraform-aws-ecs-web-app that referenced this issue Feb 25, 2021
@jhosteny
feat: update module to use new ALB ingress module
3684b90 
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes cloudposse#90.
jhosteny added a commit to thoroai/terraform-aws-ecs-web-app that referenced this issue Feb 25, 2021
@jhosteny
feat: update module to use new ALB ingress module
3edfc2c 
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes cloudposse#90.
@jhosteny jhosteny mentioned this issue Feb 25, 2021
Closed
jhosteny added a commit to thoroai/terraform-aws-ecs-web-app that referenced this issue Feb 25, 2021
@jhosteny
feat: update module to use new ALB ingress module
1b78fc3 
This change updates the ALB ingress module so that we can pass the OIDC
scope setting through unaltered.

Fixes cloudposse#90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhosteny jhosteny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update module to use new ALB ingress module thoroai/terraform-aws-ecs-web-app
1 participant
@jhosteny