Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix make update error #181

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jxs1211
Copy link
Contributor

@jxs1211 jxs1211 commented Jan 23, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #180

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no

@jxs1211
Copy link
Contributor Author

jxs1211 commented Jan 23, 2025

➜  karpenter-provider-alicloud git:(fix/make-update-error) ✗ make update
go mod tidy
go mod download
mkdir -p /Users/shen/work/dev/golang/open_source/karpenter/karpenter-provider-alicloud/bin
test -s /Users/shen/work/dev/golang/open_source/karpenter/karpenter-provider-alicloud/bin/controller-gen || GOBIN=/Users/shen/work/dev/golang/open_source/karpenter/karpenter-provider-alicloud/bin go install sigs.k8s.io/controller-tools/cmd/[email protected]
/Users/shen/work/dev/golang/open_source/karpenter/karpenter-provider-alicloud/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
hack/boilerplate.sh
hack/update-generated.sh
Password:
➜  karpenter-provider-alicloud git:(fix/make-update-error) ✗ 

@jxs1211
Copy link
Contributor Author

jxs1211 commented Jan 23, 2025

@jwcesign

Signed-off-by: shenxianjie <[email protected]>
@jxs1211 jxs1211 force-pushed the fix/make-update-error branch from 9763672 to 9025e0f Compare January 23, 2025 06:59
@jwcesign jwcesign changed the title fix make update error fix: fix make update error Jan 23, 2025
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks! @jxs1211

@Vacant2333 Vacant2333 merged commit 8dc01a2 into cloudpilot-ai:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix make update error
2 participants