Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): datetimepicker issues #269

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

franzheidl
Copy link
Contributor

@franzheidl franzheidl commented Aug 21, 2024

fix(ui): Datetimepicker issues (#68 ) WIP

-- THIS IS A WORK IN PROGRESS --

Changes Made

  • render DateTimePicker calendar into PortalProvider
  • keep positionElement tied to calendarTarget.current
  • remove css rule:
.flatpickr-calendar.open:not(.inline) {
  &[style]:not(.inline) {
    //top: auto !important; // <-- remove this!!!
    // left: auto !important;  // <-- and this!!!
  }
}

Related Issues

#68

TODO

  • use decorator to wrap all stories in PortalProvider – does not work in storybook yet?
  • test all scenarios / verify proper positioning of calendar in all possible configurations
  • what do we do if there is no PortalProvider – establish and implement fallback positionElement
  • Use js default params while at it

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: e1593b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

# Conflicts:
#	package-lock.json
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-269/
on branch gh-pages at 2024-09-19 13:11 UTC

@franzheidl franzheidl changed the title Datetimepicker issues fix(ui) Datetimepicker issues Sep 3, 2024
@franzheidl franzheidl changed the title fix(ui) Datetimepicker issues fix(ui): Datetimepicker issues Sep 4, 2024
@franzheidl franzheidl changed the title fix(ui): Datetimepicker issues fix(ui): datetimepicker issues Sep 4, 2024
@barsukov barsukov added the ui-components All tasks related to juno-ui-components library label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants