You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.
The text was updated successfully, but these errors were encountered:
Removing onKeyPress completely would be a breaking change. What I would do as a first step is add an onKeyDown handler (that does the same thing as the current onKeyPress handler) and ensure the onKeyPress prop is marked as deprecated. Then when we release the next major version we can remove it together with the other deprecated components and options.
However, having said all that, there are other components that also have onKeyPress handlers (Pagination comes to mind, maybe others, too). They should all be changed at the same time. I'll add it to our ui-components umbrella epic.
Task Description
We need to convert SearchInput and all related components from @cloudoperators/juno-ui-components to TypeScript
List of potential dependencies
Sub-tasks
Related Issues
Additional Context
Please check this online codemode editor to change the PropTypes to a proper Ts interfaces
https://github.com/mskelton/ratchet
Online editor: https://ratchet.mskelton.dev/
We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.
The text was updated successfully, but these errors were encountered: