Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvd): allow fetching of issues from 2021 to now #247 #250

Merged
merged 33 commits into from
Sep 25, 2024

Conversation

drochow
Copy link
Collaborator

@drochow drochow commented Sep 25, 2024

Description

Adds the possibility to the NVD scanner to fetch issues back from 2021 to get the complete database of NVD.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

drochow and others added 30 commits September 4, 2024 09:12
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.20.2...v1.20.3)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.23.0 to 1.23.1.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…_Matches' into issue_168/dorneanu

# Conflicts:
#	internal/app/issue_match/issue_match_handler_events.go
…68/dorneanu

# Conflicts:
#	internal/app/heureka.go
#	internal/app/issue_repository/issue_repository_handler_events.go
#	internal/app/issue_repository/issue_repository_handler_test.go
#	internal/app/service/service_handler_events.go
#	internal/app/service/service_handler_test.go
@MR2011
Copy link
Collaborator

MR2011 commented Sep 25, 2024

It looks good, but do we want to make the time window configurable now?

@drochow
Copy link
Collaborator Author

drochow commented Sep 25, 2024

It looks good, but do we want to make the time window configurable now?

So you suggest to make stat date configurable? or as well the end date?

@MR2011 MR2011 merged commit c83e8e6 into main Sep 25, 2024
7 checks passed
@MR2011 MR2011 deleted the drochow/issue-247/nvd-improvements branch September 25, 2024 11:05
@drochow drochow linked an issue Sep 26, 2024 that may be closed by this pull request
3 tasks
dustindemmerle pushed a commit that referenced this pull request Sep 26, 2024
* chore:  WIP for basic matching

* chore: updated eventHandler initialization in tests

* Change EventHandler signature and logic

* Fix tests

* Add more tests regarding concurrent processing

* chore: refactored function for lower coginitive complexity & fixed logic

* First implementation

* Wip

* Fix tests

* Fixing tests part 2

* Implement tests for BuildIssueVariantMap

* Fix tests

* Wip

* chore(deps): bump github.com/prometheus/client_golang (#210)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.20.2...v1.20.3)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump golang from 1.23.0 to 1.23.1 (#211)

Bumps golang from 1.23.0 to 1.23.1.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add tests for handling issue repositories with different priorities

* chore: removed changes unrelated to this feature

* fix: fixed imports

* fix: fixed imports

* Improve tests

* resolve issues

* feat(scanner/nvd): Adding possibility to fetch NVD from 2001

* feat: made time window configurable

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Victor Dorneanu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Reimsbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(scanner): Investigate bugs on large scale scans
3 participants