Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] - Remove propagated resources from the remote clusters #777

Closed
4 tasks
Tracked by #728
IvoGoman opened this issue Nov 25, 2024 · 0 comments · Fixed by #788
Closed
4 tasks
Tracked by #728

[FEAT] - Remove propagated resources from the remote clusters #777

IvoGoman opened this issue Nov 25, 2024 · 0 comments · Fixed by #788
Assignees
@gciezkowski-acc

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Nov 25, 2024 •
edited
Loading

Priority

medium

Description

The generic PropagationReconciler allows to propagate Greenhouse resources to a remote cluster.
This is currently the case for Teams and TeamMemberships. As part of the deprecation of this PropagationReconciler, it is necessary to first remove the remote resources.

Under normal circumstances, this will only be done if the propagates Greenhouse resource is deleted or the cluster removed from Greenhouse.

Acceptance Criteria

  • The PropagationController only runs the cleanup logic to remove resources from the remote cluster
  • The PropagationController removes the finalizer if the remote resources have been deleted
  • The PropagationController skips reconciliations if the propagation finalizer is no longer set.
  • The PropagationController only watches Resources that have the propagation finalizer set

Reference Issues

No response
@IvoGoman IvoGoman mentioned this issue Nov 25, 2024
Open
2 tasks
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Nov 25, 2024
@IvoGoman IvoGoman mentioned this issue Nov 25, 2024
Open
2 tasks
@gciezkowski-acc gciezkowski-acc self-assigned this Nov 26, 2024
gciezkowski-acc added a commit that referenced this issue Nov 28, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
7a7cf77
gciezkowski-acc added a commit that referenced this issue Nov 28, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
586bc88
gciezkowski-acc added a commit that referenced this issue Nov 28, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
bbe6d6f
gciezkowski-acc added a commit that referenced this issue Nov 29, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
9616539
gciezkowski-acc added a commit that referenced this issue Dec 2, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
f5d8e3d
gciezkowski-acc added a commit that referenced this issue Dec 5, 2024
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
1c91145 
…e cluster (#777)
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
0d08609
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
2f514f6 
…e cluster (#777)
@uwe-mayer uwe-mayer linked a pull request Jan 7, 2025 that will close this issue
feat(controller): deprecation of propagation controller #788
Merged
24 tasks
@uwe-mayer uwe-mayer moved this from Sprint Backlog to In progress in Greenhouse Core Roadmap Jan 7, 2025
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
37b1b98
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
946ca55 
…e cluster (#777)
gciezkowski-acc added a commit that referenced this issue Jan 14, 2025
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
e1f7386
gciezkowski-acc added a commit that referenced this issue Jan 14, 2025
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
15a2459 
…e cluster (#777)
gciezkowski-acc added a commit that referenced this issue Jan 17, 2025
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
a46813d
gciezkowski-acc added a commit that referenced this issue Jan 17, 2025
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
1db7165 
…e cluster (#777)
@gciezkowski-acc gciezkowski-acc mentioned this issue Jan 17, 2025
Merged
24 tasks
gciezkowski-acc added a commit that referenced this issue Jan 17, 2025
@gciezkowski-acc
feat(controllers) Remove reconciliation intervsl (#777)
359256d
gciezkowski-acc added a commit that referenced this issue Jan 17, 2025
@gciezkowski-acc
feat(controllers) Remove reconciliation intervsl (#777)
c8b41a1
gciezkowski-acc added a commit that referenced this issue Jan 27, 2025
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
aaca772
gciezkowski-acc added a commit that referenced this issue Jan 27, 2025
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
51ceb84 
…e cluster (#777)
gciezkowski-acc added a commit that referenced this issue Jan 27, 2025
@gciezkowski-acc
feat(controllers) Remove reconciliation intervsl (#777)
09b4c59
gciezkowski-acc added a commit that referenced this issue Jan 28, 2025
@gciezkowski-acc
feat(controllers) Deprecation of propagation controller (#777)
483990c
gciezkowski-acc added a commit that referenced this issue Jan 28, 2025
@gciezkowski-acc
feat(controllers) Remove filtering to propagate only changes in remot…
b83b454 
…e cluster (#777)
gciezkowski-acc added a commit that referenced this issue Jan 28, 2025
@gciezkowski-acc
feat(controllers) Remove reconciliation intervsl (#777)
2a2ba51
gciezkowski-acc added a commit that referenced this issue Jan 28, 2025
@gciezkowski-acc
feat(controller): deprecation of propagation controller (#788)
156d206 
* feat(controllers) Deprecation of propagation controller (#777)

* feat(controllers) Remove filtering to propagate only changes in remote cluster (#777)

* feat(controllers) Remove reconciliation intervsl (#777)
@github-project-automation github-project-automation bot moved this from In progress to Done in Greenhouse Core Roadmap Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gciezkowski-acc gciezkowski-acc

Labels
None yet
Projects
Greenhouse Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(controller): deprecation of propagation controller cloudoperators/greenhouse
2 participants
@IvoGoman @gciezkowski-acc