Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] - Remove deprecated NoHelmChartTestFailuresCondition #754

Closed
3 tasks done
IvoGoman opened this issue Nov 18, 2024 · 0 comments · Fixed by #863
Closed
3 tasks done

[FEAT] - Remove deprecated NoHelmChartTestFailuresCondition #754

IvoGoman opened this issue Nov 18, 2024 · 0 comments · Fixed by #863
Assignees
@ibakshay
Labels
feature

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Nov 18, 2024 •
edited
Loading

Priority

None

User Story

No response

Description

With #748 the condition NoHelmChartTestFailures has been superseded by HelmChartTestSucceeded.
Now the logic to remove the condition and the constant can be removed.

Acceptance Criteria

  • Ensure the Plugins are no longer using the status condition
  • Remove the logic for removing the deprecated status condition
  • Remove the constant NoHelmChartTestFailuresCondition

Reference Issues

No response
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Nov 18, 2024
@IvoGoman IvoGoman changed the title [FEAT] - <title> [FEAT] - Remove deprecated NoHelmChartTestFailuresCondition Nov 18, 2024
@IvoGoman IvoGoman mentioned this issue Nov 18, 2024
Merged
26 tasks
@IvoGoman IvoGoman moved this from Sprint Backlog to Todo in Greenhouse Core Roadmap Jan 8, 2025
@ibakshay ibakshay mentioned this issue Jan 27, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Greenhouse Core Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibakshay ibakshay

Labels
feature
Projects
Greenhouse Core Roadmap
Status: Done
Milestone
No milestone
2 participants
@IvoGoman @ibakshay