Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charttest): enable charts explicitly for PR charttests #389

Merged
merged 21 commits into from
Sep 18, 2024

Conversation

ibakshay
Copy link
Contributor

@ibakshay ibakshay commented Sep 13, 2024

This Pull Request:

  • Introduces a separate file .github/configs/helm-test.yaml to manage plugin names used for Helm Chart testing.
  • Adds logshipper plugin to the helm lint step during Pull Requests
  • Doesn't do helm chart test for the plugins that are not added to the .github/configs/helm-test.yaml file

resolves #341

@ibakshay ibakshay marked this pull request as draft September 13, 2024 08:36
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/kubeconfig-generator:0.1.8 already exists in OCI registry. Please increment the chart version.

Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/kubeconfig-generator:0.1.8 already exists in OCI registry. Please increment the chart version.

Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/logshipper:0.2.2 already exists in OCI registry. Please increment the chart version.

Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/logshipper:0.2.2 already exists in OCI registry. Please increment the chart version.

Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you.

@IvoGoman IvoGoman changed the title debug helm chart integration test fix(charttest): enable charts explicitly for PR charttests Sep 18, 2024
@ibakshay ibakshay merged commit 47f7e07 into main Sep 18, 2024
4 checks passed
@ibakshay ibakshay deleted the fix/341-ci-integration-tests branch September 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Chart Integration Test action fails for charts with private registry images
5 participants