-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PR Workflow with Integration Tests Using Kind Cluster #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Related: |
Awesome! What if a plugin does not provide chart tests? Does the workflow then fail? |
No, the workflow won't fail. The chart tests will only run if the tests are there in the Example output when no tests are present| ...Successfully got an update from the "alerts" chart repository
| Update Complete. ⎈Happy Helming!⎈
| Saving 1 charts
| Downloading cert-manager from repo https://charts.jetstack.io
| Deleting outdated charts
| Installing chart "cert-manager => (version: \"1.11.1\", path: \"cert-manager/charts/v1.11.0/cert-manager\")"...
| Creating namespace "cert-manager-vhe2cxypzc"...
| namespace/cert-manager-vhe2cxypzc created
| NAME: cert-manager-vhe2cxypzc
| LAST DEPLOYED: Mon Jul 29 13:42:59 2024
| NAMESPACE: cert-manager-vhe2cxypzc
| STATUS: deployed
| REVISION: 1
| TEST SUITE: None
| deployment "cert-manager-vhe2cxypzc" successfully rolled out
| deployment "cert-manager-vhe2cxypzc-cainjector" successfully rolled out
| deployment "cert-manager-vhe2cxypzc-webhook" successfully rolled out
| NAME: cert-manager-vhe2cxypzc
| LAST DEPLOYED: Mon Jul 29 13:42:59 2024
| NAMESPACE: cert-manager-vhe2cxypzc
| STATUS: deployed
| REVISION: 1
| TEST SUITE: None # <-------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Let's get this in.
This pull request improves our testing process by introducing integration tests to the existing PR workflow. Key changes include:
Local Testing:
This workflow can be tested locally using the
act
tool with the following command:Required Files:
act_pull_request.json
with the following content:.secrets
file with the following content:relates to #141