Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review SAML metadata changes #3220

Closed
fhanik opened this issue Jan 6, 2025 · 1 comment · Fixed by #3221 · May be fixed by #3222
Closed

Review SAML metadata changes #3220

fhanik opened this issue Jan 6, 2025 · 1 comment · Fixed by #3221 · May be fixed by #3222

Comments

@fhanik
Copy link
Contributor

fhanik commented Jan 6, 2025 •
edited
Loading

We noticed that the ID attribute of the SAML metadata changed between two versions of the UAA.

When setting entityID=https://localhost:443 in the UAA configuration file (uaa.yml setting login.entitytID)

UAA 77.19.0

ID="https___localhost_443" entityID="https://localhost:443"

UAA 77.23.0

ID="https://localhost:443" entityID="https://localhost:443"

The ID attribute should be a NCName and not contain colons
https://www.datypic.com/sc/xsd/t-xsd_ID.html (type="ID")

I'm opening this issue to track if other changes have occurred, and if we need to be backwards compatible
@duanemay duanemay mentioned this issue Jan 6, 2025
Merged
@strehle
Copy link
Member

strehle commented Jan 7, 2025

From https://cloudfoundry.slack.com/archives/C03FXANBV/p1736193268857739?thread_ts=1732612889.604019&cid=C03FXANBV

Signature value contains line breaks, see
https://stackoverflow.com/questions/4728300/how-to-produce-xml-signature-with-no-whitespaces-and-line-breaks-in-java

This was linked to pull requests Jan 7, 2025
Fix Metadata ID to conform to NCName #3221
Merged
Do not add whitespaces in XML signature of /saml/metadata #3222
Open
@strehle strehle moved this from Inbox to Pending Review | Discussion in Foundational Infrastructure Working Group Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Pending Review | Discussion to Done in Foundational Infrastructure Working Group Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Status: Done
Milestone
No milestone
2 participants
@fhanik @strehle