fix: support id_token_hint parameter on oidc logout #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeroda
commented
Sep 16, 2024
•
mikeroda
commented
- populate the id_token from an external oidc login into the UAA authentication
- include the id_token in an external oidc logout via the id_token_hint parameter
- fixes Support id_token_hint external oidc logout #3037
|
Thanks, I uploaded my draft but will review next days your PR. |
strehle
previously requested changes
Sep 26, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/authentication/UaaLoginHint.java
Outdated
Show resolved
Hide resolved
- populate the id_token from an external oidc login into the authentication - include the id_token in an external oidc logout via the id_token_hint parameter Change-Id: I7e4655ac8f9867a86fac2d28fdb5639386f5f54c
mikeroda
force-pushed
the
fix/id_token_hint
branch
from
8106ef9
to
e413ea1
Compare
|
The only open task for this PR would be sonar: https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=3049 and test coverage > 80 |
strehle
reviewed
Sep 27, 2024
There was a problem hiding this comment.
please add Unit Tests for new code
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=3049
Change-Id: Ie532f64f59ef7f0ed359af7975c95a8066c9d43c
strehle
approved these changes
Sep 28, 2024
...ava/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManagerTest.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthLogoutHandler.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthLogoutHandler.java
Outdated
Show resolved
Hide resolved
peterhaochen47
approved these changes
Sep 30, 2024
|
@strehle Feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.