Skip to content

Commit 2ae4ec0

Browse files
jrussettgeofffranks
jrussett
authored and
geofffranks
committed
Update to code.cloudfoundry.org/cfhttp/v2
Updates the client used to the non-deprecated cfhttp/v2 [#187603786](https://www.pivotaltracker.com/story/show/187603786)
1 parent a68c794 commit 2ae4ec0

File tree

3 files changed

+23
-35
lines changed

3 files changed

+23
-35
lines changed

‎driverhttp/remote_client.go

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@ import (
55
"context"
66
"encoding/json"
77
"errors"
8-
"fmt"
98
"io"
109
"net/http"
11-
"strings"
1210

13-
"code.cloudfoundry.org/cfhttp"
11+
"code.cloudfoundry.org/cfhttp/v2"
1412
"code.cloudfoundry.org/clock"
1513
"code.cloudfoundry.org/dockerdriver"
1614
"code.cloudfoundry.org/goshims/http_wrap"
@@ -49,28 +47,18 @@ func NewRemoteClient(url string, tls *dockerdriver.TLSConfig) (*remoteClient, er
4947
client := cfhttp.NewClient()
5048
input_url := url
5149

52-
if strings.Contains(url, ".sock") {
53-
client = cfhttp.NewUnixClient(url)
54-
url = fmt.Sprintf("unix://%s", url)
55-
} else {
56-
if tls != nil {
57-
tlsConfig, err := tlsconfig.Build(
58-
tlsconfig.WithInternalServiceDefaults(),
59-
tlsconfig.WithIdentityFromFile(tls.CertFile, tls.KeyFile),
60-
).Client(tlsconfig.WithAuthorityFromFile(tls.CAFile))
61-
if err != nil {
62-
return nil, err
63-
}
64-
65-
tlsConfig.InsecureSkipVerify = tls.InsecureSkipVerify
66-
67-
if tr, ok := client.Transport.(*http.Transport); ok {
68-
tr.TLSClientConfig = tlsConfig
69-
} else {
70-
return nil, errors.New("Invalid transport")
71-
}
50+
if tls != nil {
51+
tlsConfig, err := tlsconfig.Build(
52+
tlsconfig.WithInternalServiceDefaults(),
53+
tlsconfig.WithIdentityFromFile(tls.CertFile, tls.KeyFile),
54+
).Client(tlsconfig.WithAuthorityFromFile(tls.CAFile))
55+
if err != nil {
56+
return nil, err
7257
}
7358

59+
tlsConfig.InsecureSkipVerify = tls.InsecureSkipVerify
60+
61+
client = cfhttp.NewClient(cfhttp.WithTLSConfig(tlsConfig))
7462
}
7563

7664
driver := NewRemoteClientWithClient(url, tls, client, clock.NewClock())

‎go.mod

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ go 1.19
44

55
require (
66
code.cloudfoundry.org/cfhttp v2.0.0+incompatible
7+
code.cloudfoundry.org/cfhttp/v2 v2.0.1
78
code.cloudfoundry.org/clock v1.1.0
89
code.cloudfoundry.org/goshims v0.34.0
910
code.cloudfoundry.org/lager/v3 v3.0.3
@@ -20,15 +21,14 @@ require (
2021
github.com/go-logr/logr v1.4.1 // indirect
2122
github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572 // indirect
2223
github.com/google/go-cmp v0.6.0 // indirect
23-
github.com/google/pprof v0.0.0-20230323073829-e72429f035bd // indirect
24+
github.com/google/pprof v0.0.0-20240320155624-b11c3daa6f07 // indirect
2425
github.com/kr/pretty v0.3.1 // indirect
25-
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d // indirect
2626
github.com/nxadm/tail v1.4.11 // indirect
2727
github.com/openzipkin/zipkin-go v0.4.2 // indirect
28-
golang.org/x/mod v0.14.0 // indirect
28+
golang.org/x/mod v0.16.0 // indirect
2929
golang.org/x/net v0.24.0 // indirect
3030
golang.org/x/sys v0.19.0 // indirect
3131
golang.org/x/text v0.14.0 // indirect
32-
golang.org/x/tools v0.17.0 // indirect
32+
golang.org/x/tools v0.19.0 // indirect
3333
gopkg.in/yaml.v3 v3.0.1 // indirect
3434
)

‎go.sum

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
code.cloudfoundry.org/cfhttp v2.0.0+incompatible h1:Gk1oNYalXmkebrG9kgUtZ9+FPjQGnqZtS457RP2gWhc=
22
code.cloudfoundry.org/cfhttp v2.0.0+incompatible/go.mod h1:kwYQ8kChWl4AuUJG3vKtp1po2B91S7XoUWhoKElabmA=
3+
code.cloudfoundry.org/cfhttp/v2 v2.0.1 h1:xCbkvDVUDuFCquDo66QnvM9hG6vxM2cvTMjj/A8BcNA=
4+
code.cloudfoundry.org/cfhttp/v2 v2.0.1/go.mod h1:yD0n22D4KP4xamgTxbz82KsWzK5kcfUrmJNrrmd4YBg=
35
code.cloudfoundry.org/clock v1.1.0 h1:XLzC6W3Ah/Y7ht1rmZ6+QfPdt1iGWEAAtIZXgiaj57c=
46
code.cloudfoundry.org/clock v1.1.0/go.mod h1:yA3fxddT9RINQL2XHS7PS+OXxKCGhfrZmlNUCIM6AKo=
57
code.cloudfoundry.org/goshims v0.34.0 h1:R0t2MLPOrcqVLO8JrKSvEtE9P7t5caF5MaLrb1i4xGk=
@@ -23,16 +25,14 @@ github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572 h1:tfuBGBXKqDEe
2325
github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572/go.mod h1:9Pwr4B2jHnOSGXyyzV8ROjYa2ojvAY6HCGYYfMoC3Ls=
2426
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
2527
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
26-
github.com/google/pprof v0.0.0-20230323073829-e72429f035bd h1:r8yyd+DJDmsUhGrRBxH5Pj7KeFK5l+Y3FsgT8keqKtk=
27-
github.com/google/pprof v0.0.0-20230323073829-e72429f035bd/go.mod h1:79YE0hCXdHag9sBkw2o+N/YnZtTkXi0UT9Nnixa5eYk=
28+
github.com/google/pprof v0.0.0-20240320155624-b11c3daa6f07 h1:57oOH2Mu5Nw16KnZAVLdlUjmPH/TSYCKTJgG0OVfX0Y=
29+
github.com/google/pprof v0.0.0-20240320155624-b11c3daa6f07/go.mod h1:kf6iHlnVGwgKolg33glAes7Yg/8iWP8ukqeldJSO7jw=
2830
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
2931
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
3032
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
3133
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
3234
github.com/maxbrunsfeld/counterfeiter/v6 v6.8.1 h1:NicmruxkeqHjDv03SfSxqmaLuisddudfP3h5wdXFbhM=
3335
github.com/maxbrunsfeld/counterfeiter/v6 v6.8.1/go.mod h1:eyp4DdUJAKkr9tvxR3jWhw2mDK7CWABMG5r9uyaKC7I=
34-
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d h1:VhgPp6v9qf9Agr/56bj7Y/xa04UccTW04VP0Qed4vnQ=
35-
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d/go.mod h1:YUTz3bUH2ZwIWBy3CJBeOBEugqcmXREj14T+iG/4k4U=
3636
github.com/nxadm/tail v1.4.11 h1:8feyoE3OzPrcshW5/MJ4sGESc5cqmGkGCWlco4l0bqY=
3737
github.com/nxadm/tail v1.4.11/go.mod h1:OTaG3NK980DZzxbRq6lEuzgU+mug70nY11sMd4JXXHc=
3838
github.com/onsi/ginkgo v1.16.5 h1:8xi0RTUf59SOSfEtZMvwTvXYMzG4gV23XVHOZiXNtnE=
@@ -59,8 +59,8 @@ github.com/tedsuo/rata v1.0.0 h1:Sf9aZrYy6ElSTncjnGkyC2yuVvz5YJetBIUKJ4CmeKE=
5959
github.com/tedsuo/rata v1.0.0/go.mod h1:X47ELzhOoLbfFIY0Cql9P6yo3Cdwf2CMX3FVZxRzJPc=
6060
go.step.sm/crypto v0.16.2 h1:Pr9aazTwWBBZNogUsOqhOrPSdwAa9pPs+lMB602lnDA=
6161
golang.org/x/crypto v0.22.0 h1:g1v0xeRhjcugydODzvb3mEM9SQ0HGp9s/nh3COQ/C30=
62-
golang.org/x/mod v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
63-
golang.org/x/mod v0.14.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
62+
golang.org/x/mod v0.16.0 h1:QX4fJ0Rr5cPQCF7O9lh9Se4pmwfwskqZfq5moyldzic=
63+
golang.org/x/mod v0.16.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
6464
golang.org/x/net v0.24.0 h1:1PcaxkF854Fu3+lvBIx5SYn9wRlBzzcnHZSiaFFAb0w=
6565
golang.org/x/net v0.24.0/go.mod h1:2Q7sJY5mzlzWjKtYUEXSlBWCdyaioyXzRB2RtU8KVE8=
6666
golang.org/x/sync v0.6.0 h1:5BMeUDZ7vkXGfEr1x9B4bRcTH4lpkTkpdh0T/J+qjbQ=
@@ -69,8 +69,8 @@ golang.org/x/sys v0.19.0 h1:q5f1RH2jigJ1MoAWp2KTp3gm5zAGFUTarQZ5U386+4o=
6969
golang.org/x/sys v0.19.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
7070
golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
7171
golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
72-
golang.org/x/tools v0.17.0 h1:FvmRgNOcs3kOa+T20R1uhfP9F6HgG2mfxDv1vrx1Htc=
73-
golang.org/x/tools v0.17.0/go.mod h1:xsh6VxdV005rRVaS6SSAf9oiAqljS7UZUacMZ8Bnsps=
72+
golang.org/x/tools v0.19.0 h1:tfGCXNR1OsFG+sVdLAitlpjAvD/I6dHDKnYrpEZUHkw=
73+
golang.org/x/tools v0.19.0/go.mod h1:qoJWxmGSIBmAeriMx19ogtrEPrGtDbPK634QFIcLAhc=
7474
google.golang.org/protobuf v1.33.0 h1:uNO2rsAINq/JlFpSdYEKIZ0uKD/R9cpdv0T+yoGwGmI=
7575
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
7676
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=

0 commit comments

Comments
 (0)