Correctly map metadata #1200
Open
Correctly map metadata #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels and annotations need to be serialized under the `metadata` key.
This commit ensures that code that currently sets labels and annotations does not break
|
@JakobFels thank you for the contribution! We are working through PRs at the moment. Could you please add integration test support to cover the new feature? As an example, annotations checks can be seen in the integration-test module in places such as here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188
This change will correctly write annotations and labels to a v3 manifest. When using v3 push labels and annotations were not correctly applied/serialized.
This change consists of 2 commits. The second one ensures backward compatibility with existing code setting labels or annotations, as to not require a new major version.