Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Registrar Changes broke Stratos Functionality #3160

Open
benjaminguttmann-avtq opened this issue Sep 2, 2024 · 1 comment
Open

Route Registrar Changes broke Stratos Functionality #3160

benjaminguttmann-avtq opened this issue Sep 2, 2024 · 1 comment
Labels

Comments

@benjaminguttmann-avtq
Copy link

Subject of the issue

With the changes in v14.0.0 the registered routes for the app-autoscaler have been changed. The Autoscaler-Api no longer registers with autoscaler.((system_domain)) but with app-autoscaler.((system_domain)). Unfortunately, the value within stratos is hardcoded which means the app-autoscaler use within Stratos is not working anymore right now. Not sure if anything can be done on your side (maybe add the old route to be registered as well) but wanted to make it at least visible. I created an issue in Cloudfoundry Community Stratos Repo as well.

Your environment

  • Version of app-autoscaler-release: v14.0.0
  • Specify the database PostgreSQL 15.x along-with it's version
  • How did you deploy the release?
  • How did you run the acceptance-tests? - None
    • If you did not run them, please consider running them and attaching the output as well.

Steps to reproduce

Tell us how to reproduce this issue.

Expected behaviour

Tell us what should happen.

Actual behaviour

Tell us what happens instead.

@silvestre
Copy link
Member

Hi @benjaminguttmann-avtq ,

the route is set in https://github.com/cloudfoundry/app-autoscaler-release/blame/912cbd185e60e5099342d723d5a242dbb07d5451/templates/app-autoscaler.yml#L296 and the line is there since the start of this file.

I see that the old (deleted) deployment manifest did hardcode it to autoscaler while the new one set its to the variable ((deployment_name)).

We can think about switching the default to hardocde again autoscaler but we currently depend on the fact that we can deploy app-autoscaler-release multiple times in the same foundation for our CI, so we would need to introduce an operations file restoring the current behavior in order not to break our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants