Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Column header cell's become buttons #667

Open
rorgonas opened this issue Mar 1, 2017 · 2 comments
Open

Column header cell's become buttons #667

rorgonas opened this issue Mar 1, 2017 · 2 comments

Comments

@rorgonas
Copy link

rorgonas commented Mar 1, 2017

After the last build update from v0.3.7 to v0.3.8 our header cell's become buttons.

Checked in commit. We can see following changes:

  1. lib/backgrid.css: header cells element selector has been changes
 @@ -62,8 +62,11 @@
    background-color: #f9f9f9;
  }
  
 -.backgrid thead th a {
 +.backgrid thead th button {
    display: block;
 +  padding: 0;
 +  background: none;
 +  border: none;
  }
  1. api/output/Backgrid.HeaderCell.js
    <code>{&quot;click button&quot;: &quot;onClick&quot;}</code>

Please confirm if this is a bug or a new feature. Thank.

@daneshka
Copy link

daneshka commented Mar 1, 2017

This is not a bug fix. You shouldn't release this feature as a bug fix. 0.3.8 just broke our release in the last day 😞

@mr-feek
Copy link

mr-feek commented Mar 26, 2017

0.3.8 is not backwards compatible. It broke my app. Please fix and bump minor version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants