diff --git a/src/workerd/io/trace-streaming-test.c++ b/src/workerd/io/trace-streaming-test.c++ index b131310882f..1a50848706a 100644 --- a/src/workerd/io/trace-streaming-test.c++ +++ b/src/workerd/io/trace-streaming-test.c++ @@ -154,8 +154,7 @@ KJ_TEST("We can create a simple, streaming trace session with a single explicitl streamingTrace->setEventInfo(trace::FetchEventInfo( kj::HttpMethod::GET, kj::str("http://example.com"), kj::String(), {})); - auto span = - KJ_ASSERT_NONNULL(streamingTrace->newChildSpan(0 * kj::MILLISECONDS + kj::UNIX_EPOCH)); + auto span = KJ_ASSERT_NONNULL(streamingTrace->newChildSpan()); span->addMark("bar"); // Intentionally not calling setOutcome on the span. streamingTrace->setOutcome(trace::Outcome(EventOutcome::CANCELED)); diff --git a/src/workerd/io/trace-streaming.c++ b/src/workerd/io/trace-streaming.c++ index 098761ba6d9..c4a3ae0e47e 100644 --- a/src/workerd/io/trace-streaming.c++ +++ b/src/workerd/io/trace-streaming.c++ @@ -173,7 +173,7 @@ void StreamingTrace::addDropped(uint32_t start, uint32_t end) { } kj::Maybe> StreamingTrace::newChildSpan( - kj::Date timestamp, trace::Tags tags, Options options) { + trace::Tags tags, Options options) { KJ_IF_SOME(i, impl) { KJ_REQUIRE_NONNULL(i->onsetInfo.info, "the event info must be set before other events"); return kj::heap(spans, *this, 0, kj::mv(tags), options); @@ -395,7 +395,7 @@ void StreamingTrace::Span::addCustom(trace::Tags&& tags) { } kj::Maybe> StreamingTrace::Span::newChildSpan( - kj::Date timestamp, trace::Tags tags, Options options) { + trace::Tags tags, Options options) { KJ_IF_SOME(i, impl) { return kj::heap(spans, i->trace, i->id, kj::mv(tags), options); } diff --git a/src/workerd/io/trace-streaming.h b/src/workerd/io/trace-streaming.h index 1c45be6a467..270680e67ce 100644 --- a/src/workerd/io/trace-streaming.h +++ b/src/workerd/io/trace-streaming.h @@ -184,7 +184,7 @@ class StreamingTrace final: public SpanBase { void addSubrequestOutcome(trace::SubrequestOutcome&& outcome) override; void addCustom(trace::Tags&& tags) override; kj::Maybe> newChildSpan( - kj::Date timestamp, trace::Tags tags = nullptr, Options options = Options::NONE); + trace::Tags tags = nullptr, Options options = Options::NONE); // Setting the outcome of the span explicitly closes the span, after which // no further events can be emitted. @@ -234,7 +234,7 @@ class StreamingTrace final: public SpanBase { void addSubrequestOutcome(trace::SubrequestOutcome&& outcome) override; void addCustom(trace::Tags&& tags) override; kj::Maybe> newChildSpan( - kj::Date timestamp, trace::Tags tags = nullptr, Options options = Options::NONE); + trace::Tags tags = nullptr, Options options = Options::NONE); private: struct Impl;