Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cloudflare_notification_policies of type "Traffic Anomalies" and "Cloudflare Incident Alert" #2840

Closed
r-kok opened this issue Oct 12, 2023 · 3 comments · Fixed by #2901
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Milestone

Comments

@r-kok
Copy link

r-kok commented Oct 12, 2023

Current Terraform and Cloudflare provider version

Terraform v1.5.7
provider 4.16

Description

The 4.16 version of the provider supports the cloudflare_notification_policy resources.
However notification types Traffic-Anomalies and Cloudflare Incident Alert do not work properly, yet.
The request is to support these as well.

Use cases

Make notifications of all types terraform-managed.

Currently, we can create and edit all notification types in the Cloudflare dashboard,
and we can import some resources into terraform but not all:

When I try to import to resources:

import {
  to = cloudflare_notification_policy.Traffic-Anomalies
  id = "REDACTED_ACCOUNT_ID/REDACTED_POLICY_ID"
}

import {
  to = cloudflare_notification_policy.Cloudflare-Incident-Alert
  id = "REDACTED_ACCOUNT_ID/REDACTED_POLICY_ID"
  }
  
 Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: failed to set filters: Invalid address to set: []string{"filters", "0", "incident_impact"}
│
│ Error: failed to set filters: Invalid address to set: []string{"filters", "0", "selectors"}

Potential Terraform configuration

...

References

#2759

@r-kok r-kok added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2023
@github-actions
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added this to the v4.19.0 milestone Nov 2, 2023
@jacobbednarz jacobbednarz removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 2, 2023
@bporter816
Copy link

To resolve this, would we also need support for traffic_anomalies_alert type? This still seems to be unimplemented.

Copy link
Contributor

This functionality has been released in v4.19.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants