Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fight_mode cannot be enabled under cloudflare_bot_management #2803

Closed
2 tasks done
tpalts opened this issue Sep 28, 2023 · 2 comments · Fixed by #2833
Closed
2 tasks done

fight_mode cannot be enabled under cloudflare_bot_management #2803

tpalts opened this issue Sep 28, 2023 · 2 comments · Fixed by #2833
Labels
kind/bug Categorizes issue or PR as related to a bug. service/bot_management Categorizes issue or PR as related to the Bot Management service. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log.
Milestone

Comments

@tpalts
Copy link

tpalts commented Sep 28, 2023

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.5.7
on darwin_amd64

  • provider registry.terraform.io/cloudflare/cloudflare v4.15.0

Affected resource(s)

cloudflare_bot_management

Terraform configuration files

terraform {
  required_providers {
    cloudflare = {
      source = "cloudflare/cloudflare"
      version = "4.15.0"
    }
  }
}

provider "cloudflare" {
  api_token = "REDACTED"
}

variable "zone_id" {
  default = "REDACTED"
}

resource "cloudflare_bot_management" "bot-management-settings" {
  zone_id = "REDACTED"
  enable_js = true
  fight_mode = true
}

Link to debug output

https://gist.github.com/tpalts/a54d196af1a441d871d1c1b016e0b4a1

Panic output

No response

Expected output

Bot fight mode should be enabled.

resource "cloudflare_bot_management" "bot-management-settings" {
    fight_mode = true
# ...
}

Actual output

Bot fight mode is not enabled.

resource "cloudflare_bot_management" "bot-management-settings" {
    fight_mode = false
# ...
}

Steps to reproduce

  1. terraform apply

Additional factoids

From the logs, it looks like when the request is made to the Cloudflare API, only enable_js is passed, but not fight_mode.

References

No response

@tpalts tpalts added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 28, 2023
@github-actions
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log. label Sep 28, 2023
@jacobbednarz jacobbednarz added triage/accepted Indicates an issue or PR is ready to be actively worked on. service/bot_management Categorizes issue or PR as related to the Bot Management service. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2023
@github-actions github-actions bot added this to the v4.17.0 milestone Oct 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. service/bot_management Categorizes issue or PR as related to the Bot Management service. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants