Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid key on valid prometheus keep_firing_for property #712

Closed
tl-eirik-albrigtsen opened this issue Sep 7, 2023 · 1 comment
Closed
Assignees

Comments

@tl-eirik-albrigtsen
Copy link

The keep_firing_for field was added to prometheus alerts in prometheus/prometheus#11827 which landed in 2.42.0 and is also supported in prometheus-operator in prometheusrules.

when running pint lint prod/ (say) on a folder with prometheusrules containing the property a yaml/parse error triggers on all alerts with this key:

prod/thanos-alerts.yaml:294 Fatal: invalid key(s) found: keep_firing_for (yaml/parse)
 294 |       keep_firing_for: 5m

pint version at 0.45.0 (revision: Homebrew)

am running a relaxed "yaml/parse" setup with .pint.hcl containing:

parser {
  relaxed = [ "(.*)", "yaml/parse" ]
}

to support prometheusrule usage but this does not seem to suppress the error. not sure if there are other ways to ignore this error explicitly.

at any rate it would be nice to have this property supported!

@prymitive prymitive self-assigned this Sep 7, 2023
@prymitive
Copy link
Collaborator

Fixed in #713 713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants