You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The server sends channel_max in the Tune frame, which is defined as:
Specifies highest channel number that the server permits. Usable channel numbers are in the range 1..channel-max. Zero indicates no specified limit.
The client responds with channel_max in the TuneOk frame, which is defined as:
The maximum total number of channels that the client will use per connection.
If the client specifies a channel max that is higher than the value provided by the server, the server MUST close the connection without attempting a negotiated close. The server may report the error in some fashion to assist implementors.
The spec also includes assertions that the client can't specify a value larger that the server:
Describe the bug
The server sends
channel_max
in theTune
frame, which is defined as:The client responds with
channel_max
in theTuneOk
frame, which is defined as:The spec also includes assertions that the client can't specify a value larger that the server:
This is also mentioned in RabbitMQs documentation:
https://www.rabbitmq.com/docs/channels#channel-max
LavinMQ currently just accepts the value the client sends in
TuneOK
lavinmq/src/lavinmq/amqp/client.cr
Line 45 in 20ebdb0
Describe your setup
Please describe the environment you are using, e.g. LavinMQ version, operating system, client software.
How to reproduce
Only verified by reading the code so far, we should create a spec
Expected behavior
The client should not be able to set a value higher that what the server suggests
The text was updated successfully, but these errors were encountered: