Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Build Image Build Process #407

Open
3 tasks
drewbo opened this issue Feb 8, 2023 · 2 comments
Open
3 tasks

Review Build Image Build Process #407

drewbo opened this issue Feb 8, 2023 · 2 comments
Labels
squad-pages Pages squad label

Comments

@drewbo
Copy link
Contributor

drewbo commented Feb 8, 2023

In conjunction with #248 we should review what is included in the build image and how it is built. In particular:

  • Chrome (used for puppeteer) is included in every build container despite not currently being used (the template repositories contain pa11y-ci which relies on puppeteer but it is run via GitHub actions). This makes M1 docker builds difficult, slows down the build, and adds 450MB to the final image.
  • Sometimes the RVM GPG keyservers fail the build on CI for no apparent reason. There isn't an easy way to add rvm without this but we should consider only having certain versions of ruby available (and using separate images) rather than allowing an install at runtime.

Acceptance Criteria

@drewbo drewbo added the squad-pages Pages squad label label Mar 23, 2023
@drewbo
Copy link
Contributor Author

drewbo commented Mar 23, 2023

Reiterating the second point here that we should reconsider how we handle language versions (i.e. can we support multiple build images rather than switching the version at runtime), especially in light of #412

@drewbo
Copy link
Contributor Author

drewbo commented Mar 23, 2023

Here's the first step in using multiple containers/images: cloud-gov/pages-builder#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad-pages Pages squad label
Projects
None yet
Development

No branches or pull requests

1 participant