Introduce orchard.inspect/nav-to-item
#213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Nov 12, 2023
| (keep (fn [[k v]] | ||
| (or (some->> (nav obj k v) |
There was a problem hiding this comment.
Note the deletion of nav, explained in the comment below.
I'd say it was a bug - deftests were showing that we were performing nav over the same items repeatedly, which can be expensive in the face of side-effects.
| @@ -941,32 +958,6 @@ | |||
| (:newline)) | |||
| (datafy-section rendered)))))))) | |||
|
|
|||
| (deftest inspect-navigable-metadata-extension-test | |||
There was a problem hiding this comment.
Test deleted as it was based on eagerly calling nav.
The added test already shows the behavior for when calling nav intentionally.
|
Hmm, the basic idea works but this will need some refinements since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209