-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test suite for :cljs branches #150
Comments
The context is me looking into an issue @vemv raised on cljdoc. He had an awesome idea that I was exploring, and initial experiments look promising for cljdoc Clojure analysis. But when the cljdoc analyzer saw cljc files in orchard, it tried ClojureScript analysis and that failed. I was wondering if this failure was cljdoc's or orchard's. So I dug into orchard (a very wee bit) to see if there were cljs tests. I do see |
This gets cider/orchard past the reported problem, but there is another issue in the library itself: clojure-emacs/orchard#150 (comment) Closes cljdoc#487
FWIW, cljdoc now allows you to select which languages are analyzed. {:cljdoc/languages ["clj"]} Lemme know if you want a PR. |
Nice feature! PR would be perfect, thanks! Same for cider-nrepl, refactor-nrepl |
Doesn't address clojure-emacs#150 but should allow docs to build under cljdoc.
@vemv, PR done for this repo, for your next release to clojars, cljdoc should build fine, feel free to ping me if there are any issues. I had a quick look at the following for you:
|
Doesn't address #150 but should allow docs to build under cljdoc.
Cheers! 🍻 Both projects depend on Orchard, so starting there seems on the safe side. |
There are a few
:cljs
branches in our reader conditionals, but there isn't a cljs runner in our CI.This means an important hole in test coverage.
(Thanks for spotting this @lread)
The text was updated successfully, but these errors were encountered: