Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite for :cljs branches #150

Open
vemv opened this issue Jan 23, 2022 · 5 comments
Open

Run test suite for :cljs branches #150

vemv opened this issue Jan 23, 2022 · 5 comments

Comments

@vemv
Copy link
Member

vemv commented Jan 23, 2022

There are a few :cljs branches in our reader conditionals, but there isn't a cljs runner in our CI.

This means an important hole in test coverage.

(Thanks for spotting this @lread)

@lread
Copy link
Contributor

lread commented Jan 24, 2022

The context is me looking into an issue @vemv raised on cljdoc. He had an awesome idea that I was exploring, and initial experiments look promising for cljdoc Clojure analysis. But when the cljdoc analyzer saw cljc files in orchard, it tried ClojureScript analysis and that failed. I was wondering if this failure was cljdoc's or orchard's.

So I dug into orchard (a very wee bit) to see if there were cljs tests. I do see test-cljs/orchard/cljs but don't understand if/how these are run.

lread added a commit to lread/cljdoc that referenced this issue Feb 7, 2022
This gets cider/orchard past the reported problem, but there is another
issue in the library itself:

clojure-emacs/orchard#150 (comment)

Closes cljdoc#487
@lread
Copy link
Contributor

lread commented Mar 3, 2022

FWIW, cljdoc now allows you to select which languages are analyzed.
To only have cljdoc analyze for clj (and not cljs), a ./doc/cljdoc.edn with the following contents should do the trick:

{:cljdoc/languages ["clj"]}

Lemme know if you want a PR.

@vemv
Copy link
Member Author

vemv commented Mar 3, 2022

Nice feature!

PR would be perfect, thanks! Same for cider-nrepl, refactor-nrepl

lread added a commit to lread/orchard that referenced this issue Mar 4, 2022
Doesn't address clojure-emacs#150 but should allow docs to build under cljdoc.
@lread
Copy link
Contributor

lread commented Mar 4, 2022

PR would be perfect, thanks! Same for cider-nrepl, refactor-nrepl

@vemv, PR done for this repo, for your next release to clojars, cljdoc should build fine, feel free to ping me if there are any issues.

I had a quick look at the following for you:

  • cider-nrepl - seems like cljdoc is failing to analyze for clj so not the same issue.
  • refactor-nrepl - also a clj analysis failure
    Lemme know if you want help getting these working on cljdoc and we'll see what we can do, but probably better to visit cljdoc slack channel and/or raise cljdoc GitHub issues.

vemv pushed a commit that referenced this issue Mar 4, 2022
Doesn't address #150 but should allow docs to build under cljdoc.
@vemv
Copy link
Member Author

vemv commented Mar 5, 2022

Cheers! 🍻

Both projects depend on Orchard, so starting there seems on the safe side.

vemv added a commit to clojure-emacs/refactor-nrepl that referenced this issue Mar 5, 2022
vemv added a commit to clojure-emacs/refactor-nrepl that referenced this issue Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants