-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macroexpand-1 doesn't work on clojurescript #2099
Comments
See what are the messages exchanged between CIDER and nREPL as described here http://cider.readthedocs.io/en/latest/troubleshooting/ I see we've got an cljs implementation for the macroexpansion, so in theory everything should be working fine. |
Through experimentation I've confirmed that the problem goes all the way down to I suspect this has to do with For posterity (older Slack messages eventually become unavailable):
|
Well, passing |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
any progress? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
Any chance this might get renewed attention? I just recently started work in a large ClojureScript codebase that makes extensive use of macros. It's fun times — I've been away from Clojure/Script for some years, and it's great to be back. Today I tried to use the CIDER is awesome 🚀 , and still useful for ClojureScript even if macro expansion isn't working as hoped, but it would be a big deal for me and probably for many other developers if it did work. I would be glad to help fix it, but after digging around at the problem for several hours today, I wasn't able to figure out what's going wrong. As of the start of today, I had completely forgotten that back in 2013, when I was neck deep in Clojure/Script, I was struggling with macro expansion and I wrote some helpers that mostly worked: https://gist.github.com/michaelsbradleyjr/7509505 While doing some googl'ing re: I tried adapting that code to present-day ClojureScript. Long-short is that with a |
related code: Someone else also encounter this issue: |
@michaelsbradleyjr i just someone who has built a clever workaround for the whole "macroexpend in macros in cljs" problem flowstorm instrument |
Steps to reproduce the problem
With
project.clj
above, I was able to launch a figwheel repl.In
core.cljs
, I have an om component defined like belowWhen I expand this macro using
C-c RET
, it didn't expand at all, in*cider-macroexpansion*
buffer I got the same thing back, however, if I expand this manually, macroexpand did work.Is there anything I was missing?
Thanks in advance.
Environment & Version information
CIDER version information
Lein/Boot version
Leiningen 2.7.1 on Java 1.8.0_144 Java HotSpot(TM) 64-Bit Server VM
Emacs version
GNU Emacs 25.3.1 (x86_64-apple-darwin16.7.0) of 2017-09-12
Operating system
macOS Sierra 10.12.6
The text was updated successfully, but these errors were encountered: