Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sidebar footer if languages list is non-empty OR formats list is non-empty #42

Open
chrispcampbell opened this issue Jul 8, 2023 · 0 comments
Open

Show sidebar footer if languages list is non-empty OR formats list is non-empty #42

chrispcampbell opened this issue Jul 8, 2023 · 0 comments
Assignees
@chrispcampbell
Labels
improvement Internal improvement or refactoring

Comments

@chrispcampbell
Copy link
Contributor

Currently docs-builder hides the sidebar footer if the languages list is empty. But in the case where there are no translations but PDF output is enabled, this means the sidebar footer is hidden and the PDF link is inaccessible.

We should fix the logic that controls visibility of the sidebar footer so that it shows it if the languages list is non-empty OR the formats list is non-empty (and conditionally show the individual sections depending on their presence).
@chrispcampbell chrispcampbell added the improvement Internal improvement or refactoring label Jul 8, 2023
@chrispcampbell chrispcampbell self-assigned this Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrispcampbell chrispcampbell

Labels
improvement Internal improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrispcampbell