Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure as default? #1

Open
manveru opened this issue Jul 16, 2022 · 1 comment
Open

Pure as default? #1

manveru opened this issue Jul 16, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@manveru
Copy link

manveru commented Jul 16, 2022

Is there any reason that impure is the default right now? I'd think that the reverse should be the case, since you probably want purity if you use this project in the first place.

@clhodapp
Copy link
Owner

This would be my preference too but it seems kind of complex to do while the implementation is a simple sed processor. Right now, I essentially turn #!pure into an --unset PATH flag for nix shell in the runner. It's a lot harder to have magic comments remove flags from nix shell than to add them. I do really want to keep the option of preserving PATH because just blindly clearing it is over-limiting in my experience.

@clhodapp clhodapp added the enhancement New feature or request label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants