more tests

cleverage · Apr 25, 2024 · 650343d · 650343d
1 parent 42a7293
commit 650343d
Show file tree

Hide file tree

Showing 18 changed files with 245 additions and 125 deletions.
diff --git a/src/Transformer/Xml/XpathEvaluatorTransformer.php b/src/Transformer/Xml/XpathEvaluatorTransformer.php
@@ -112,7 +112,6 @@ public function buildXpath(\DOMNode $node): \DOMXPath
 
     public function query(\DOMXPath $xpath, string $query, \DOMNode $node, array $options): mixed
     {
-        // TODO check if query is relative ?
         $nodeList = $xpath->query($query, $node);
         $results = iterator_to_array($nodeList);
 

diff --git a/tests.old/Transformer/XpathEvaluatorTransformerTest.php b/tests.old/Transformer/XpathEvaluatorTransformerTest.php
@@ -21,66 +21,6 @@
  */
 class XpathEvaluatorTransformerTest extends AbstractProcessTest
 {
-    public function testSimpleQuery(): void
-    {
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML('<a>ok</a>');
-        $this->assertTransformation('xpath_evaluator', 'ok', $domDocument, [
-            'query' => '/a/text()',
-        ]);
-    }
-
-    public function testAttributeValueQuery(): void
-    {
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML('<node data="ok">ko</node>');
-        $this->assertTransformation('xpath_evaluator', 'ok', $domDocument, [
-            'query' => '/node/@data',
-        ]);
-    }
-
-    public function testSubQuery(): void
-    {
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML('<a><b><c>ok</c></b></a>');
-
-        $node = $domDocument->getElementsByTagName('b')[0];
-        $this->assertTransformation('xpath_evaluator', 'ok', $node, [
-            'query' => './c/text()',
-        ]);
-    }
-
-    public function testMultiResults(): void
-    {
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML('<a><b><c>ok1</c><c>ok2</c><c>ok3</c></b></a>');
-
-        $node = $domDocument->getElementsByTagName('b')[0];
-        $this->assertTransformation('xpath_evaluator', ['ok1', 'ok2', 'ok3'], $node, [
-            'query' => './c/text()',
-            'single_result' => false,
-        ]);
-    }
-
-    public function testMultiResultsAsNodeList(): void
-    {
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML('<a><b><c>ok1</c><c>ok2</c><c>ok3</c></b></a>');
-
-        $node = $domDocument->getElementsByTagName('b')[0];
-        /** @var \DOMNodeList $result */
-        $result = $this->transform('xpath_evaluator', $node, [
-            'query' => './c/text()',
-            'single_result' => false,
-            'unwrap_value' => false,
-        ]);
-
-        self::assertCount(3, $result);
-        self::assertEquals('ok1', $result[0]->textContent);
-        self::assertEquals('ok2', $result[1]->textContent);
-        self::assertEquals('ok3', $result[2]->textContent);
-    }
-
     public function testMultiQuery(): void
     {
         $domDocument = new \DOMDocument();

diff --git a/tests/Exception/MissingTransformerExceptionTest.php b/tests/Exception/MissingTransformerExceptionTest.php
@@ -7,10 +7,13 @@
 use CleverAge\ProcessBundle\Exception\MissingTransformerException;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Exception\MissingTransformerException
+ */
 class MissingTransformerExceptionTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Exception\MissingTransformerException::create
+     * @covers ::create
      */
     public function testCreate(): void
     {

diff --git a/tests/Transformer/ArrayElementTransformerTest.php b/tests/Transformer/ArrayElementTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\ArrayElementTransformer
+ */
 class ArrayElementTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayElementTransformer::transform
+     * @covers ::transform
      */
     public function testTransformReturnsNthElementFromArray(): void
     {
@@ -34,7 +37,7 @@ public function testTransformReturnsNthElementFromArray(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayElementTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptionsSetsRequiredOptions(): void
     {
@@ -50,7 +53,7 @@ public function testConfigureOptionsSetsRequiredOptions(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayElementTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCodeReturnsCorrectCode(): void
     {

diff --git a/tests/Transformer/ArrayFirstTransformerTest.php b/tests/Transformer/ArrayFirstTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer
+ */
 class ArrayFirstTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer::transform
+     * @covers ::transform
      */
     public function testTransformReturnsFirstElementIfIterableAndAllowed(): void
     {
@@ -34,7 +37,7 @@ public function testTransformReturnsFirstElementIfIterableAndAllowed(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer::transform
+     * @covers ::transform
      */
     public function testTransformReturnsValueIfNotIterableAndAllowed(): void
     {
@@ -50,7 +53,7 @@ public function testTransformReturnsValueIfNotIterableAndAllowed(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer::transform
+     * @covers ::transform
      */
     public function testTransformThrowsExceptionIfNotIterableAndNotAllowed(): void
     {
@@ -64,7 +67,7 @@ public function testTransformThrowsExceptionIfNotIterableAndNotAllowed(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCodeReturnsCorrectCode(): void
     {
@@ -76,7 +79,7 @@ public function testGetCodeReturnsCorrectCode(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ArrayFirstTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptionsSetsDefaultOptions(): void
     {

diff --git a/tests/Transformer/CastTransformerTest.php b/tests/Transformer/CastTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\CastTransformer
+ */
 class CastTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::transform
+     * @covers ::transform
      */
     public function testCastToInt(): void
     {
@@ -35,7 +38,7 @@ public function testCastToInt(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::transform
+     * @covers ::transform
      */
     public function testCastToFloat(): void
     {
@@ -50,7 +53,7 @@ public function testCastToFloat(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::transform
+     * @covers ::transform
      */
     public function testCastToString(): void
     {
@@ -65,7 +68,7 @@ public function testCastToString(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::transform
+     * @covers ::transform
      */
     public function testCastToBool(): void
     {
@@ -80,7 +83,7 @@ public function testCastToBool(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::transform
+     * @covers ::transform
      */
     public function testCastToInvalidType(): void
     {
@@ -94,7 +97,7 @@ public function testCastToInvalidType(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptionsSetsRequiredOptions(): void
     {
@@ -110,7 +113,7 @@ public function testConfigureOptionsSetsRequiredOptions(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\CastTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCodeReturnsCorrectCode(): void
     {

diff --git a/tests/Transformer/ConstantTransformerTest.php b/tests/Transformer/ConstantTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\ConstantTransformer
+ */
 class ConstantTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ConstantTransformer::transform
+     * @covers ::transform
      */
     public function testTransform(): void
     {
@@ -34,7 +37,7 @@ public function testTransform(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ConstantTransformer::transform
+     * @covers ::transform
      */
     public function testTransformWithNullValue(): void
     {
@@ -48,7 +51,7 @@ public function testTransformWithNullValue(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ConstantTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptions(): void
     {
@@ -61,7 +64,7 @@ public function testConfigureOptions(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\ConstantTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCodeReturnsCorrectCode(): void
     {

diff --git a/tests/Transformer/DateFormatTransformerTest.php b/tests/Transformer/DateFormatTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\DateFormatTransformer
+ */
 class DateFormatTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateFormatTransformer::transform
+     * @covers ::transform
      */
     public function testTransformValidDate(): void
     {
@@ -35,7 +38,7 @@ public function testTransformValidDate(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateFormatTransformer::transform
+     * @covers ::transform
      */
     public function testTransformInvalidDate(): void
     {
@@ -49,7 +52,7 @@ public function testTransformInvalidDate(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateFormatTransformer::transform
+     * @covers ::transform
      */
     public function testTransformNullValue(): void
     {
@@ -64,7 +67,7 @@ public function testTransformNullValue(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateFormatTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCode(): void
     {
@@ -76,7 +79,7 @@ public function testGetCode(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateFormatTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptions(): void
     {

diff --git a/tests/Transformer/DateParserTransformerTest.php b/tests/Transformer/DateParserTransformerTest.php
@@ -17,10 +17,13 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @coversDefaultClass \CleverAge\ProcessBundle\Transformer\DateParserTransformer
+ */
 class DateParserTransformerTest extends TestCase
 {
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::transform
+     * @covers ::transform
      */
     public function testTransformValidDate(): void
     {
@@ -35,7 +38,7 @@ public function testTransformValidDate(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::transform
+     * @covers ::transform
      */
     public function testTransformInvalidDate(): void
     {
@@ -49,7 +52,7 @@ public function testTransformInvalidDate(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::transform
+     * @covers ::transform
      */
     public function testTransformNullValue(): void
     {
@@ -63,7 +66,7 @@ public function testTransformNullValue(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::transform
+     * @covers ::transform
      */
     public function testTransformDateTimeObject(): void
     {
@@ -78,7 +81,7 @@ public function testTransformDateTimeObject(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::getCode
+     * @covers ::getCode
      */
     public function testGetCode(): void
     {
@@ -90,7 +93,7 @@ public function testGetCode(): void
     }
 
     /**
-     * @covers \CleverAge\ProcessBundle\Transformer\DateParserTransformer::configureOptions
+     * @covers ::configureOptions
      */
     public function testConfigureOptions(): void
     {