From 74d22caa066941a0bb6855025b735b88449edb86 Mon Sep 17 00:00:00 2001 From: panteliselef Date: Mon, 31 Mar 2025 19:57:07 +0300 Subject: [PATCH 1/2] chore(clerk-js): Remove non-actionable error from Session poller --- .changeset/fresh-numbers-sink.md | 5 +++++ packages/clerk-js/src/core/auth/AuthCookieService.ts | 12 +++++------- packages/clerk-js/src/core/errors.ts | 4 ---- 3 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 .changeset/fresh-numbers-sink.md diff --git a/.changeset/fresh-numbers-sink.md b/.changeset/fresh-numbers-sink.md new file mode 100644 index 00000000000..d813b559e41 --- /dev/null +++ b/.changeset/fresh-numbers-sink.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Remove non-actionable error from Session poller. diff --git a/packages/clerk-js/src/core/auth/AuthCookieService.ts b/packages/clerk-js/src/core/auth/AuthCookieService.ts index 6fd67cae50e..80a2d2da447 100644 --- a/packages/clerk-js/src/core/auth/AuthCookieService.ts +++ b/packages/clerk-js/src/core/auth/AuthCookieService.ts @@ -1,10 +1,10 @@ import { createCookieHandler } from '@clerk/shared/cookie'; import { setDevBrowserJWTInURL } from '@clerk/shared/devBrowser'; -import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError } from '@clerk/shared/error'; +import { is4xxError } from '@clerk/shared/error'; import { noop } from '@clerk/shared/utils'; import type { Clerk, InstanceType } from '@clerk/types'; -import { clerkCoreErrorTokenRefreshFailed, clerkMissingDevBrowserJwt } from '../errors'; +import { clerkMissingDevBrowserJwt } from '../errors'; import { eventBus, events } from '../events'; import type { FapiClient } from '../fapiClient'; import type { ClientUatCookieHandler } from './cookies/clientUat'; @@ -181,18 +181,16 @@ export class AuthCookieService { } private handleGetTokenError(e: any) { - //throw if not a clerk api error (aka fapi error) and not a network error - if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e)) { - clerkCoreErrorTokenRefreshFailed(e.message || e); - } - //sign user out if a 4XX error if (is4xxError(e)) { void this.clerk.handleUnauthenticated().catch(noop); return; } + + // -------- // Treat any other error as a noop // TODO(debug-logs): Once debug logs is available log this error. + // -------- } /** diff --git a/packages/clerk-js/src/core/errors.ts b/packages/clerk-js/src/core/errors.ts index 304a1716dde..33609f0287e 100644 --- a/packages/clerk-js/src/core/errors.ts +++ b/packages/clerk-js/src/core/errors.ts @@ -46,10 +46,6 @@ export function clerkMissingFapiClientInResources(): never { throw new Error(`${errorPrefix} Missing FAPI client in resources.`); } -export function clerkCoreErrorTokenRefreshFailed(message: string): never { - throw new Error(`${errorPrefix} Token refresh failed (error='${message}')`); -} - export function clerkOAuthCallbackDidNotCompleteSignInSignUp(type: 'sign in' | 'sign up'): never { throw new Error( `${errorPrefix} Something went wrong initializing Clerk during the ${type} flow. Please contact support.`, From 227ff5762d764c07f4675c3c597f2428bb86971e Mon Sep 17 00:00:00 2001 From: panteliselef Date: Wed, 2 Apr 2025 18:08:59 +0300 Subject: [PATCH 2/2] address pr feedback --- packages/clerk-js/src/core/auth/AuthCookieService.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/clerk-js/src/core/auth/AuthCookieService.ts b/packages/clerk-js/src/core/auth/AuthCookieService.ts index 80a2d2da447..0e352e8a638 100644 --- a/packages/clerk-js/src/core/auth/AuthCookieService.ts +++ b/packages/clerk-js/src/core/auth/AuthCookieService.ts @@ -1,6 +1,6 @@ import { createCookieHandler } from '@clerk/shared/cookie'; import { setDevBrowserJWTInURL } from '@clerk/shared/devBrowser'; -import { is4xxError } from '@clerk/shared/error'; +import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError, isNetworkError } from '@clerk/shared/error'; import { noop } from '@clerk/shared/utils'; import type { Clerk, InstanceType } from '@clerk/types'; @@ -181,6 +181,11 @@ export class AuthCookieService { } private handleGetTokenError(e: any) { + //early return if not a clerk api error (aka fapi error) and not a network error + if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e) && !isNetworkError(e)) { + return; + } + //sign user out if a 4XX error if (is4xxError(e)) { void this.clerk.handleUnauthenticated().catch(noop);