diff --git a/.changeset/fresh-numbers-sink.md b/.changeset/fresh-numbers-sink.md new file mode 100644 index 00000000000..d813b559e41 --- /dev/null +++ b/.changeset/fresh-numbers-sink.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Remove non-actionable error from Session poller. diff --git a/packages/clerk-js/src/core/auth/AuthCookieService.ts b/packages/clerk-js/src/core/auth/AuthCookieService.ts index 6fd67cae50e..0e352e8a638 100644 --- a/packages/clerk-js/src/core/auth/AuthCookieService.ts +++ b/packages/clerk-js/src/core/auth/AuthCookieService.ts @@ -1,10 +1,10 @@ import { createCookieHandler } from '@clerk/shared/cookie'; import { setDevBrowserJWTInURL } from '@clerk/shared/devBrowser'; -import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError } from '@clerk/shared/error'; +import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError, isNetworkError } from '@clerk/shared/error'; import { noop } from '@clerk/shared/utils'; import type { Clerk, InstanceType } from '@clerk/types'; -import { clerkCoreErrorTokenRefreshFailed, clerkMissingDevBrowserJwt } from '../errors'; +import { clerkMissingDevBrowserJwt } from '../errors'; import { eventBus, events } from '../events'; import type { FapiClient } from '../fapiClient'; import type { ClientUatCookieHandler } from './cookies/clientUat'; @@ -181,9 +181,9 @@ export class AuthCookieService { } private handleGetTokenError(e: any) { - //throw if not a clerk api error (aka fapi error) and not a network error - if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e)) { - clerkCoreErrorTokenRefreshFailed(e.message || e); + //early return if not a clerk api error (aka fapi error) and not a network error + if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e) && !isNetworkError(e)) { + return; } //sign user out if a 4XX error @@ -191,8 +191,11 @@ export class AuthCookieService { void this.clerk.handleUnauthenticated().catch(noop); return; } + + // -------- // Treat any other error as a noop // TODO(debug-logs): Once debug logs is available log this error. + // -------- } /** diff --git a/packages/clerk-js/src/core/errors.ts b/packages/clerk-js/src/core/errors.ts index 304a1716dde..33609f0287e 100644 --- a/packages/clerk-js/src/core/errors.ts +++ b/packages/clerk-js/src/core/errors.ts @@ -46,10 +46,6 @@ export function clerkMissingFapiClientInResources(): never { throw new Error(`${errorPrefix} Missing FAPI client in resources.`); } -export function clerkCoreErrorTokenRefreshFailed(message: string): never { - throw new Error(`${errorPrefix} Token refresh failed (error='${message}')`); -} - export function clerkOAuthCallbackDidNotCompleteSignInSignUp(type: 'sign in' | 'sign up'): never { throw new Error( `${errorPrefix} Something went wrong initializing Clerk during the ${type} flow. Please contact support.`,