Skip to content

Commit db213aa

Browse files
committed
doc: add note to contributor docs about warranted PR's
1 parent 222e627 commit db213aa

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

CONTRIBUTING.md

+2
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ At this stage one should expect comments and review from other contributors. You
119119
can add more commits to your pull request by committing them locally and pushing
120120
to your fork until you have satisfied all feedback.
121121

122+
Note: Code review is a burdensome but important part of the development process, and as such, certain types of pull requests are rejected. In general, if the **improvements** do not warrant the **review effort** required, the PR has a high chance of being rejected. It is up to the PR author to convince the reviewers that the changes warrant the review effort, and if reviewers are "Concept NAK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes.
123+
122124
Squashing Commits
123125
---------------------------
124126
If your pull request is accepted for merging, you may be asked by a maintainer

0 commit comments

Comments
 (0)