Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enhanced search/filter feature for discovered files #973

Open
bduranc opened this issue Apr 13, 2022 · 2 comments
Open

Comments

@bduranc
Copy link

bduranc commented Apr 13, 2022

Issue Type: Feature Request
Issue Description:

Related issue(s): #953

Problem

The new UI brings noticeable performance improvements when browsing individual file discoveries when compared to the old one.

However, it lacks the ability to apply search filters across all files in the project as tree view, something the old UI would let you do.

image

This makes it difficult for users to efficiently identify and resolve cases like "NOASSERTION" or "OTHER" due to the fact that the individual files (sometimes many) need to be filtered down and examined.

But as made apparent in issue #953, the new UI appears only to apply the search filter within the folder depth you are currently in.

Take the following case, for example:

We are in the root of the project's source tree and can see there are two license discoveries we can filter down.

image

First, we select BSD-3-Clause option which shows us there are some files under this license already present in the root directory.

image

Next, we want to look at the NOASSERTION findings, but unfortunately nothing is shown when that option is selected.

image

However, we're still determined to turn over that NOASSERTION stone, so we take a detour and search the raw data.

This extra effort reveals that the ./m4 directory as well as a few others have a NOASSERTION discovery.

image

And... if we apply the same NOASSERTION filter within that directory, we see it filters down to just that one result.

image

So from how it appears, the column filter in the current Files tab only shows items in the user's current "working" directory.

Solution Proposed

Implement a "global file search" either as an independent and separate search field, or as "enhanced" version of the current column-based filter that can be configured by the user to show files outside their current working directory depth.

@bduranc
Copy link
Author

bduranc commented Oct 13, 2023

Here is another, more simple example:

https://clearlydefined.io/definitions/git/github/vitejs/vite/cd82648b0f96a0b7c0826c5b7bc7b4ab4f37d836

Filter works fine for files in same directory:

image

But does nothing if I filter within a (sub)directory that does not have a matching file (yet option is still shown):

image

When I drill more into that folder, then you see there is another MIT discovery, and the filter works there again.

@bduranc
Copy link
Author

bduranc commented Nov 22, 2023

Can confirm as of 11/22/2023 this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant