Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testlib: when creating a bundle, if using -t it should also install the bundle #1480

Open
castulo opened this issue Apr 20, 2020 · 1 comment
Labels

Comments

@castulo
Copy link
Contributor

castulo commented Apr 20, 2020

The create_bundle function has a flag L to indicate the bundle has to be "installed" in the test target root, and it also has a flag t to indicate the bundle is "tracked". At the moment, a bundle can be tracked but not installed, this doesn't make sense since if a bundle is tracked it should also be installed. We should be able to create bundles that are not tracked, and we can use L for that, but all tracked bundles t should be installed without having to specify the L flag.

@otaviobp
Copy link
Contributor

Instead of having one single function that does many complex operations it's better to have multiple functions that do simple operations.

There are multiple problems created by this fact, like:

  • Performace/usability trade-offs like the one reported on Testlib: remove the “partial” feature if speed is no longer an issue #1483
  • Code duplication in create_bundle/update_bundle
  • Compatibility is hard to maintain (for example, it's hard to make sure that creating a bundle with one file will be the same as creating a bundle and them adding one file to it, because the code is different.)

So, right now, the feature -L don't guarantee that the bundle will be completely installed in the system, because you don't know if the bundle will be changed later by update_bundle.
Instead it would be better to have one function that install the bundle and the user could call that at any time to install the bundle to the system in the state that the bundle is at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants