Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

[mixer] Inject Swupd_Root.pem when custom signing #88

Closed
wants to merge 1 commit into from
Closed

[mixer] Inject Swupd_Root.pem when custom signing #88

wants to merge 1 commit into from

Conversation

gtkramer
Copy link
Contributor

@gtkramer gtkramer commented Dec 13, 2019

When a user is replacing the signing function of mixer with their own
custom implementation, which implies the --no-signing option is being
used, the user is also responsible for injecting the Swupd_Root.pem into
the full chroot. This is required because swupd is hard-coded by
default to look for the update content certificate in
/usr/share/clear/update-ca/Swupd_Root.pem.

Mixer has a not well-documented feature to support adding sideloaded
content that does not come from a package by creating files in the
SERVER_STATE_DIR which the name <bundle>-extra-files. Because the
content certificate is required for swupd, we inject into the
os-core-update bundle.

Closes #85

Signed-off-by: George T Kramer [email protected]

build/mixer.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mbelluzzo mbelluzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove the heredoc usage.

When a user is replacing the signing function of mixer with their own
custom implementation, which implies the `--no-signing` option is being
used, the user is also responsible for injecting the Swupd_Root.pem into
the full chroot.  This is required because swupd is hard-coded by
default to look for the update content certificate in
/usr/share/clear/update-ca/Swupd_Root.pem.

Mixer has a not well-documented feature to support adding sideloaded
content that does not come from a package by creating files in the
SERVER_STATE_DIR which the name `<bundle>-extra-files`.  Because the
content certificate is required for swupd, we inject into the
os-core-update bundle.

Signed-off-by: George T Kramer <[email protected]>
Copy link
Contributor

@mbelluzzo mbelluzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbelluzzo
Copy link
Contributor

merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject certificate used by sign_update function into mixer's chroot
2 participants