Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version detection dropping letters #490

Open
thiagomacieira opened this issue Oct 2, 2019 · 1 comment
Open

Version detection dropping letters #490

thiagomacieira opened this issue Oct 2, 2019 · 1 comment
Labels
bug A defect in autospec's operation

Comments

@thiagomacieira
Copy link
Contributor

thiagomacieira commented Oct 2, 2019 •
edited by phmccarty
Loading 

$ cat Makefile 
PKG_NAME := mesa
URL = https://gitlab.freedesktop.org/mesa/mesa/-/archive/c64f30546d87a19e2aec34e202919571e9b0c868/mesa-19.2+637-gc64f30546d8.tar.bz2
ARCHIVES = 

include ../common/Makefile.common
$ grep Version *.spec
Version  : 19.2+637.64f30546d8

What happened to the "g" and "c" ?
@phmccarty
Copy link
Contributor

"gc" is currently a banned substring in the version parsed from the source URL, so it is stripped out during the parse phase. If we unban it, there is one package URL that is mis-parsed:

https://github.com/ivmai/bdwgc/archive/gc7_6_0.tar.gz

Without banning the substring, the parsed version is gc7.6.0 instead of 7.6.0.

One option to fix is for autospec to learn about the flavor of version string you've listed, and also that the banned substring stripping should not apply any time that flavor is encountered.

@phmccarty phmccarty added the bug A defect in autospec's operation label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in autospec's operation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phmccarty @thiagomacieira