Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Go packages should build using go version specified by runtime #257

Open
jodh-intel opened this issue Jan 23, 2018 · 3 comments
Open

Go packages should build using go version specified by runtime #257

jodh-intel opened this issue Jan 23, 2018 · 3 comments

Comments

@jodh-intel
Copy link

We're building golang packages using go 1.9.2 from:

However, we're testing with go 1.8.3 from:

We should build the binaries using the same version of go used by the runtime (1.8.3) so I think the packaging scripts should:

$ go get -d github.com/clearcontainers/runtime
export go_version=$(grep ^go_version= versions.txt|cut -d= -f2-)
@erick0z
Copy link

erick0z commented Jan 25, 2018

@jodh-intel Looking at the Jenkins logs, it seems we are testing with go 1.9.2. Maybe the runtime go version from https://github.com/clearcontainers/runtime/blob/master/versions.txt#L40 is outdated?

@jodh-intel
Copy link
Author

Hi @erick0z - actually, I think Jenkins is doing the wrong thing. I've raised clearcontainers/jenkins#37 on the issue.

@jodh-intel
Copy link
Author

Thanks for spotting that btw!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants