Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

ci: enable go static checkers #46

Open
grahamwhaley opened this issue Jul 7, 2017 · 1 comment
Open

ci: enable go static checkers #46

grahamwhaley opened this issue Jul 7, 2017 · 1 comment

Comments

@grahamwhaley
Copy link
Contributor

As far as I can tell we are not running any of the go static checkers on this repo. It doesn't look like we invoke them from our .ci or that they are invoked from the clearcontainers/tests scrips we invoke either. I also checked the Travis logs and could see no evidence.
We should probably start by importing the go-static-checks.sh script once we have a nicely fixed up version - see clearcontainers/tests#110 for more info.

btw, currently the repo seems to be showing no problems from a hand run of the static checkers - take a bow the relevant developers :-)

@grahamwhaley
Copy link
Contributor Author

I note, houndci that we use on this repo uses golint for checking go code already - so we could drop that from the go-static-checks script if we need, but the overheads are probably small enough to just leave it be unless it becomes an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant