You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just noticed that the default flag2refine2.f90 checks not only eta vs. wave_tolerance but also speed against a list of speed_tolerance values based on the level. I had forgotten we do this, which is related to #454.
But my concern at the moment is the default is a list of 6 huge values set in data.py.
Since they are huge, no cell will ever get flagged. But why check this up to 6 times for every cell in flag2refine? Shouldn't the default be a list of length 1? Or better yet of length 0 so this check is never done? That might not read in properly in refinement_module.f90, however, so we shouldn't work to hard on this until we address #454 and incorporate this too.
In the meantime, make it a list of length 1?
The text was updated successfully, but these errors were encountered:
If I remember correctly this was a product of some logic that made the coding easier but may have been more expensive than intended. It looks like if speed_tolerance is set to zero length then it will skip that loop entirely. That may be a better solution?
I just noticed that the default
flag2refine2.f90
checks not only eta vs.wave_tolerance
but also speed against a list ofspeed_tolerance
values based on the level. I had forgotten we do this, which is related to #454.But my concern at the moment is the default is a list of 6 huge values set in data.py.
Since they are huge, no cell will ever get flagged. But why check this up to 6 times for every cell in
flag2refine
? Shouldn't the default be a list of length 1? Or better yet of length 0 so this check is never done? That might not read in properly inrefinement_module.f90
, however, so we shouldn't work to hard on this until we address #454 and incorporate this too.In the meantime, make it a list of length 1?
The text was updated successfully, but these errors were encountered: