Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default speed_tolerance - why list of length 6? #463

Open
rjleveque opened this issue Jul 18, 2020 · 1 comment
Open

default speed_tolerance - why list of length 6? #463

rjleveque opened this issue Jul 18, 2020 · 1 comment
Assignees

Comments

@rjleveque
Copy link
Member

I just noticed that the default flag2refine2.f90 checks not only eta vs. wave_tolerance but also speed against a list of speed_tolerance values based on the level. I had forgotten we do this, which is related to #454.

But my concern at the moment is the default is a list of 6 huge values set in data.py.

Since they are huge, no cell will ever get flagged. But why check this up to 6 times for every cell in flag2refine? Shouldn't the default be a list of length 1? Or better yet of length 0 so this check is never done? That might not read in properly in refinement_module.f90, however, so we shouldn't work to hard on this until we address #454 and incorporate this too.

In the meantime, make it a list of length 1?

@mandli
Copy link
Member

mandli commented Jul 19, 2020

If I remember correctly this was a product of some logic that made the coding easier but may have been more expensive than intended. It looks like if speed_tolerance is set to zero length then it will skip that loop entirely. That may be a better solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants