Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECE metrics need rounding on some simple tests #15

Open
perellonieto opened this issue Mar 26, 2021 · 0 comments
Open

ECE metrics need rounding on some simple tests #15

perellonieto opened this issue Mar 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@perellonieto
Copy link
Member

The current code creates some floating point precision problems when subtracting a probability of 0.9 for a positive sample, in which ECE should be 0.1 but it seems to be 0.09999999999999. I had to round the number and print it in order to pass the doctest, but I wonder if this precision issue can be avoided.

https://github.com/perellonieto/PyCalib/blob/master/pycalib/metrics.py#L460

@perellonieto perellonieto added the enhancement New feature or request label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant