Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverridingBool prevents auto derivation of various classes #2754

Closed
martijnbastiaan opened this issue Jul 13, 2024 · 2 comments · Fixed by #2764
Closed

OverridingBool prevents auto derivation of various classes #2754

martijnbastiaan opened this issue Jul 13, 2024 · 2 comments · Fixed by #2764
Labels
enhancement good-first-issue

Comments

@martijnbastiaan
Copy link
Member

See #2711 (comment). We could remove a whole bunch of code if we were to define our own (isomorphic) version of OverridingBool.
@martijnbastiaan martijnbastiaan mentioned this issue Jul 13, 2024
Merged
2 tasks
@leonschoorl
Copy link
Member

We use the OverridingBool because we have to pass it to GHC's api here, possibly in other places too.

Instead of defining our own version and converting from/to GHC's version, we could also just derive the required (orphan) instances for OverridingBool.

@martijnbastiaan
Copy link
Member Author

I don't think that's a good idea. Orphan instances break everyone's code that had the same idea.

martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Add COverridingBool
c10c695 
Fixes #2754
martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Add COverridingBool
03d22d0 
Fixes #2754
@martijnbastiaan martijnbastiaan mentioned this issue Jul 21, 2024
Merged
2 tasks
martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Add COverridingBool
4c3bf54 
Fixes #2754
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@martijnbastiaan
Add COverridingBool
0f390b2 
Fixes #2754
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@martijnbastiaan
Add own version of OverridingBool
93a54c8 
Fixes #2754
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@martijnbastiaan
Add own version of OverridingBool
60af3d7 
Fixes #2754
mergify bot pushed a commit that referenced this issue Jul 26, 2024
@martijnbastiaan @mergify
Add own version of OverridingBool (#2764)
dd82b3e 
Fixes #2754

(cherry picked from commit 1d49cd2)

# Conflicts:
#	clash-lib/clash-lib.cabal
#	clash-lib/src/Clash/Driver/Types.hs
@mergify mergify bot mentioned this issue Jul 26, 2024
Merged
2 tasks
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@martijnbastiaan
Add own version of OverridingBool (#2764)
1d5e5a9 
Fixes #2754

(cherry picked from commit 1d49cd2)
martijnbastiaan added a commit that referenced this issue Jul 27, 2024
@martijnbastiaan
Add own version of OverridingBool (#2764)
9d07a92 
Fixes #2754

(cherry picked from commit 1d49cd2)
martijnbastiaan added a commit that referenced this issue Jul 27, 2024
@mergify @martijnbastiaan
Add own version of OverridingBool (#2764) (#2777)
1dcede3 
Fixes #2754

(cherry picked from commit 1d49cd2)

Co-authored-by: Martijn Bastiaan <[email protected]>
jvnknvlgl pushed a commit that referenced this issue Aug 26, 2024
@martijnbastiaan @jvnknvlgl
Add own version of OverridingBool (#2764)
b7d1852 
Fixes #2754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add own version of OverridingBool clash-lang/clash-compiler
2 participants
@leonschoorl @martijnbastiaan