Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringsearch is abandoned #2726

Closed
locallycompact opened this issue May 27, 2024 · 2 comments · Fixed by #2765
Closed

stringsearch is abandoned #2726

locallycompact opened this issue May 27, 2024 · 2 comments · Fixed by #2765
Labels
good-first-issue

Comments

@locallycompact
Copy link

clash-lib has a dependency on stringsearch which has been abandoned and has no accessible source on bitbucket.

https://hackage.haskell.org/package/stringsearch

Would the preference here be to fork it from tarball and request maintainership, or replace this library with something else? (Not sure what)
@martijnbastiaan
Copy link
Member

We only use it here:

clash-compiler/clash-lib/tools/v16-upgrade-primitives.hs

Line 94 in e6522d7

go bs (orig,temp) = replace (ByteString.toStrict temp) orig bs

There are probably ways to remove that dependency :).

martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Remove stringsearch dependency
14e20dc 
Fixes #2726
martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Remove stringsearch dependency
b589b72 
Fixes #2726
@martijnbastiaan martijnbastiaan mentioned this issue Jul 21, 2024
Merged
2 tasks
martijnbastiaan added a commit that referenced this issue Jul 21, 2024
@martijnbastiaan
Remove stringsearch dependency
2c786c9 
Fixes #2726
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@martijnbastiaan
Remove stringsearch dependency (#2765)
75dbbeb 
Fixes #2726
mergify bot pushed a commit that referenced this issue Jul 26, 2024
@martijnbastiaan @mergify
Remove stringsearch dependency (#2765)
b42025b 
Fixes #2726

(cherry picked from commit 75dbbeb)
@mergify mergify bot mentioned this issue Jul 26, 2024
Merged
2 tasks
martijnbastiaan added a commit that referenced this issue Jul 26, 2024
@mergify @martijnbastiaan
Remove stringsearch dependency (#2765) (#2774)
5c3f119 
Fixes #2726

(cherry picked from commit 75dbbeb)

Co-authored-by: Martijn Bastiaan <[email protected]>
jvnknvlgl pushed a commit that referenced this issue Aug 26, 2024
@martijnbastiaan @jvnknvlgl
Remove stringsearch dependency (#2765)
8ba6712 
Fixes #2726
@christiaanb
Copy link
Member

We've released v1.8.2, which includes a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stringsearch dependency clash-lang/clash-compiler
3 participants
@christiaanb @locallycompact @martijnbastiaan