Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring CMDIDataImpl #193

Open
wowasa opened this issue Sep 5, 2023 · 0 comments
Open

Refactoring CMDIDataImpl #193

wowasa opened this issue Sep 5, 2023 · 0 comments
Assignees

Comments

@wowasa
Copy link
Collaborator

wowasa commented Sep 5, 2023

Reducing the information on the necessary information:

  • we're splitting by type while extending CMDIDataBaseImpl to unite the in curation again, since we don't need to know the resource type there but only mime-type and URL. Therefore we should only implement CMDIData but not extend CMDIDataBaseImpl
  • we're storing instances of ValueSet in CMDIDataImpl but we only need a view information of the ValueSet. Hence the add methods should already select the information we need for storage
@wowasa wowasa self-assigned this Sep 5, 2023
wowasa added a commit that referenced this issue Sep 7, 2023
@wowasa wowasa changed the title Refactoring if CMDIDataImpl Refactoring CMDIDataImpl Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant