Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt OpenSKOS client to changed API #30

Open
twagoo opened this issue Feb 20, 2017 · 0 comments
Open

Adapt OpenSKOS client to changed API #30

twagoo opened this issue Feb 20, 2017 · 0 comments
Assignees

Comments

@twagoo
Copy link
Member

twagoo commented Feb 20, 2017

  • The conceptScheme parameter for find-concepts needs to be replaced withscheme

@olhsha provided the following feedback:

CLAVAS:

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/VocabularyServiceServlet.java#L57

-> conceptscheme , conceptscheme/{id}[.html]

Check:

  1. ok: http://145.100.58.150/clavas/public/api/conceptscheme/
  2. ok: http://145.100.58.150/clavas/public/api/conceptscheme/d6b89a32-f6fb-4637-9ac9-8413e46fd26a
  3. ok: http://145.100.58.150/clavas/public/api/conceptscheme/d6b89a32-f6fb-4637-9ac9-8413e46fd26a.html

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/VocabularyServiceServlet.java#L65

-> find-concepts

Check:

  1. conceptScheme parameter in the list of parameters is obsolete. I have made it "scheme" so it is the same as in picturae code (used by Beeld en Geluid)
  2. According to run these examples, it should work for parameters you need, after correcting conceptScheme to scheme.

ok: http://145.100.58.150/clavas/public/api/find-concepts?q=uri:*&scheme=http://openskos.meertens.knaw.nl/Organisations&rows=500
ok: http://145.100.58.150/clavas/public/api/find-concepts?q=uri:*505*&scheme=http://openskos.meertens.knaw.nl/Organisations&rows=500&fl=prefLabel

CCR:

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/ConceptRegistryServlet.java#L82

  1. Examples similar to examples above, like

ok: http://145.100.58.150/ccr/public/api/find-concepts?q=*&scheme=http://hdl.handle.net/11148/CCR_P-Morphosyntax_c99c78ee-1425-c8f3-33e3-fe2a4b2ec7ca
ok: http://145.100.58.150/ccr/public/api/find-concepts?q=*A*&scheme=http://hdl.handle.net/11148/CCR_P-Morphosyntax_c99c78ee-1425-c8f3-33e3-fe2a4b2ec7ca
ok: http://145.100.58.150/ccr/public/api/find-concepts?q=A&wholeword=true (new! "wholeword")

Need to know exact query parameters you use for CCR, for more thorough check.

@twagoo twagoo self-assigned this Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant