Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude slf4j binding from library #3

Open
twagoo opened this issue Jul 15, 2016 · 1 comment
Open

Exclude slf4j binding from library #3

twagoo opened this issue Jul 15, 2016 · 1 comment

Comments

@twagoo
Copy link
Member

twagoo commented Jul 15, 2016

The pom-file declares dependency on the slf4j logback binding. This can be problematic when using the toolkit as a java library. Suggestion: make a build profile for the conversion tool and define the log bindings in that profile only.
@benhur1999
Copy link

Another idea: split library and conversion-tool in two artifacts and only add the dependency to logback to the tool. The library, of course, needs a dependent on slf4j-api (which is fine, IMHO).
It's handled in a similar fashion in the cmdi-validator

twagoo added a commit that referenced this issue Jul 15, 2016
@twagoo
Made separate build profile for the upgrade tool. Refs #3
647c230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benhur1999 @twagoo