-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemaSpec: affiliation has to affiliate person with organization #177
Comments
Quite a mess, thanks for spotting it. I would say:
In general, I would propose - and this is most likely another issue - to have per-corpus "fix" scripts, so we can change encodings for the better, without breaking validity. And then, when the ParlaMint I partners start making their new corpora, tell them to either fix their scripts, or simply use the fix-XX.xsl script for V3. |
Ok, I have carried away due to my future ideas about attribute In the case of organizations in teiHeader: If we assume that if the name of the organization is similar, the organizations are identical, then we can merge all organizations to solution 1.
Ok, creating an issue on v2tov3 fixings #183 |
The way affiliations refer to organisations is now fixed, so nothing more to do here, closing. |
Element
<affiliation>
should affiliate a person with an organization with a role. I don't want to discuss here@role
, it should be done in a separate issue. I want to discuss the relationship between person and organization. I believe there are three ways how it can be implemented:affiliation/@ref
attribute to referorg/@xml:id
, which can be supported byaffiliation/@ana
(@corresp
would be better, but it is for another discussion improper usage of ana attibute #80) that points to the event related to suchorg
.affiliation/@key
where the value should be some well-known name of an organization such as "OSN". This can be used when we don't want to introduce this organization inlistOrg
, but the name is quite determinate.affiliation
element. This should be admitted when other options fail.With respect to above observations, I have discovered the following bugs (the list is not definitely complete)
BG missing affiliation reference:
ParlaMint/Data/ParlaMint-BG/ParlaMint-BG.xml
Line 8456 in 4c61c8d
@ref
contains URL:ParlaMint/Data/ParlaMint-BG/ParlaMint-BG.xml
Lines 8129 to 8131 in 4c61c8d
CZ (sorry for that, we changed the organization that represented the term onto the event and I did not think about the consequences enough.)
where the
@ref
target is event:and should be organization, the correct solution is:
DK missing affiliation reference
ParlaMint/Data/ParlaMint-DK/ParlaMint-DK.xml
Line 5344 in 4c61c8d
GB affiliation with category:
HR missing affiliation reference
ParlaMint/Data/ParlaMint-HR/ParlaMint-HR.xml
Line 535 in 4c61c8d
HU missing affiliation reference
ParlaMint/Data/ParlaMint-HU/ParlaMint-HU.xml
Line 503 in 4c61c8d
IS affiliation with government event (related to CZ case above)
ParlaMint/Data/ParlaMint-IS/ParlaMint-IS.xml
Lines 11593 to 11597 in bc6257e
IT affiliation with government event (see IS)
ParlaMint/Data/ParlaMint-IT/ParlaMint-IT.xml
Lines 903 to 906 in bc6257e
LT missing
@ref="#S"
https://github.com/clarin-eric/ParlaMint/blob/4c61c8d78c76929aac85140efce080ca86e39754/Data/ParlaMint-LT/ParlaMint-LT.xml#L3928
NL missing affiliation reference
ParlaMint/Data/ParlaMint-NL/ParlaMint-NL.xml
Line 572 in 4c61c8d
PL missing affiliation reference
ParlaMint/Data/ParlaMint-PL/ParlaMint-PL.xml
Line 470 in 4c61c8d
@TomazErjavec, do we want to fix these issues? I wanted to make
@ref
obligatory, but I am not sure about that - as it would break most of the corpora.The text was updated successfully, but these errors were encountered: