Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deterministic shuffle #47

Open
connorkuehl opened this issue Mar 15, 2019 · 2 comments
Open

Implement deterministic shuffle #47

connorkuehl opened this issue Mar 15, 2019 · 2 comments
Labels
revision This issue addresses a comment on our official RFC patche set

Comments

@connorkuehl
Copy link

std::shuffle is insufficient for the same implementation-defined reasons as why std::default_random_engine is insufficient.

Per comment: https://reviews.llvm.org/D59254#1428656
@connorkuehl
Copy link
Author

On the revision, Module::createRNG was mentioned which may be applicable here, but not code complete as they suggest some of its patches are still floating around on Phabricator.

@connorkuehl
Copy link
Author

I think it's only the overloaded version of std::shuffle which does not receive a PRNG is implementation-defined.

See https://en.cppreference.com/w/cpp/algorithm/random_shuffle

I could be wrong though...

@connorkuehl connorkuehl added the revision This issue addresses a comment on our official RFC patche set label Mar 15, 2019
@shawnl shawnl mentioned this issue Jul 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
revision This issue addresses a comment on our official RFC patche set
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@connorkuehl